Rietveld Code Review Tool
Help | Bug tracker | Discussion group | Source code | Sign in
(428)

Issue 29376835: Issue 4769 - Supporting adding whitelisted websites on ABP for Samsung Internet (Closed)

Can't Edit
Can't Publish+Mail
Start Review
Created:
3 years, 1 month ago by diegocarloslima
Modified:
2 years, 11 months ago
Reviewers:
René Jeschke, anton
CC:
Felix Dahlke
Visibility:
Public.

Description

Issue 4769 - Supporting adding whitelisted websites on ABP for Samsung Internet

Patch Set 1 #

Total comments: 24

Patch Set 2 : Removing some Java7 features and some code style adjustment #

Total comments: 1

Patch Set 3 : Adjusting Russian string #

Unified diffs Side-by-side diffs Delta from patch set Stats (+553 lines, -32 lines) Patch
A res/layout/empty_view.xml View 1 1 chunk +4 lines, -0 lines 0 comments Download
A res/layout/whitelisted_website_delete_widget.xml View 1 chunk +11 lines, -0 lines 0 comments Download
M res/values-de/strings.xml View 1 chunk +9 lines, -0 lines 0 comments Download
M res/values-el/strings.xml View 1 chunk +9 lines, -0 lines 0 comments Download
M res/values-es/strings.xml View 1 chunk +9 lines, -0 lines 0 comments Download
M res/values-fr/strings.xml View 1 chunk +9 lines, -0 lines 0 comments Download
M res/values-it/strings.xml View 1 chunk +9 lines, -0 lines 0 comments Download
M res/values-ko/strings.xml View 1 chunk +9 lines, -0 lines 0 comments Download
M res/values-nl/strings.xml View 1 chunk +9 lines, -0 lines 0 comments Download
M res/values-pl/strings.xml View 1 chunk +9 lines, -0 lines 0 comments Download
M res/values-pt/strings.xml View 1 chunk +9 lines, -0 lines 0 comments Download
M res/values-ru/strings.xml View 1 2 1 chunk +9 lines, -0 lines 0 comments Download
M res/values-tr/strings.xml View 1 chunk +9 lines, -0 lines 0 comments Download
M res/values/strings.xml View 1 chunk +9 lines, -0 lines 0 comments Download
M res/values/sysstrings.xml View 1 chunk +1 line, -0 lines 0 comments Download
M res/xml/preferences_main.xml View 1 chunk +7 lines, -0 lines 0 comments Download
A src/org/adblockplus/sbrowser/contentblocker/UrlInputOpenerPreference.java View 1 chunk +166 lines, -0 lines 0 comments Download
A src/org/adblockplus/sbrowser/contentblocker/WhitelistedWebsitesPreferenceCategory.java View 1 1 chunk +194 lines, -0 lines 0 comments Download
M src/org/adblockplus/sbrowser/contentblocker/engine/Downloader.java View 1 1 chunk +1 line, -1 line 0 comments Download
M src/org/adblockplus/sbrowser/contentblocker/engine/Engine.java View 1 9 chunks +57 lines, -15 lines 0 comments Download
M src/org/adblockplus/sbrowser/contentblocker/engine/Subscription.java View 1 1 chunk +1 line, -1 line 0 comments Download
M src/org/adblockplus/sbrowser/contentblocker/engine/Subscriptions.java View 1 2 2 chunks +3 lines, -15 lines 0 comments Download

Messages

Total messages: 9
diegocarloslima
3 years, 1 month ago (2017-02-22 22:42:57 UTC) #1
anton
https://codereview.adblockplus.org/29376835/diff/29376836/res/layout/empty_view.xml File res/layout/empty_view.xml (right): https://codereview.adblockplus.org/29376835/diff/29376836/res/layout/empty_view.xml#newcode5 res/layout/empty_view.xml:5: android:orientation="vertical"/> is "orientation" property required for View? https://codereview.adblockplus.org/29376835/diff/29376836/res/values-fr/strings.xml File ...
3 years ago (2017-03-06 09:36:33 UTC) #2
Felix Dahlke
https://codereview.adblockplus.org/29376835/diff/29376836/src/org/adblockplus/sbrowser/contentblocker/WhitelistedWebsitesPreferenceCategory.java File src/org/adblockplus/sbrowser/contentblocker/WhitelistedWebsitesPreferenceCategory.java (right): https://codereview.adblockplus.org/29376835/diff/29376836/src/org/adblockplus/sbrowser/contentblocker/WhitelistedWebsitesPreferenceCategory.java#newcode45 src/org/adblockplus/sbrowser/contentblocker/WhitelistedWebsitesPreferenceCategory.java:45: public WhitelistedWebsitesPreferenceCategory(Context context, AttributeSet attrs) On 2017/03/06 09:36:32, anton ...
3 years ago (2017-03-07 15:43:39 UTC) #3
anton
https://codereview.adblockplus.org/29376835/diff/29376836/src/org/adblockplus/sbrowser/contentblocker/WhitelistedWebsitesPreferenceCategory.java File src/org/adblockplus/sbrowser/contentblocker/WhitelistedWebsitesPreferenceCategory.java (right): https://codereview.adblockplus.org/29376835/diff/29376836/src/org/adblockplus/sbrowser/contentblocker/WhitelistedWebsitesPreferenceCategory.java#newcode45 src/org/adblockplus/sbrowser/contentblocker/WhitelistedWebsitesPreferenceCategory.java:45: public WhitelistedWebsitesPreferenceCategory(Context context, AttributeSet attrs) On 2017/03/07 15:43:38, Felix ...
3 years ago (2017-03-09 09:57:40 UTC) #4
diegocarloslima
https://codereview.adblockplus.org/29376835/diff/29376836/res/layout/empty_view.xml File res/layout/empty_view.xml (right): https://codereview.adblockplus.org/29376835/diff/29376836/res/layout/empty_view.xml#newcode5 res/layout/empty_view.xml:5: android:orientation="vertical"/> On 2017/03/06 09:36:31, anton wrote: > is "orientation" ...
3 years ago (2017-03-09 20:15:04 UTC) #5
anton
On 2017/03/09 20:15:04, diegocarloslima wrote: > https://codereview.adblockplus.org/29376835/diff/29376836/res/layout/empty_view.xml > File res/layout/empty_view.xml (right): > > https://codereview.adblockplus.org/29376835/diff/29376836/res/layout/empty_view.xml#newcode5 > ...
3 years ago (2017-03-10 06:58:12 UTC) #6
anton
https://codereview.adblockplus.org/29376835/diff/29379624/res/values-ru/strings.xml File res/values-ru/strings.xml (right): https://codereview.adblockplus.org/29376835/diff/29379624/res/values-ru/strings.xml#newcode40 res/values-ru/strings.xml:40: <string name="whitelist_website_invalid_url_error">Неверная URL</string> Emailed Tamara (CCed Diego) about it
3 years ago (2017-03-10 06:58:21 UTC) #7
Felix Dahlke
René - could you review this and move me to CC then? It's not that ...
3 years ago (2017-03-16 17:20:14 UTC) #8
René Jeschke
2 years, 11 months ago (2017-04-12 09:51:32 UTC) #9
LGTM
Sign in to reply to this message.

Powered by Google App Engine
RSS Feeds Recent Issues | This issue
This is Rietveld 87257f5