Noissue - Adding support for tel link scheme in Source.resolve_link of CMS

cms/sources.py

 # This file is part of the Adblock Plus web scripts,
 # Copyright (C) 2006-2016 Eyeo GmbH
 #
 # Adblock Plus is free software: you can redistribute it and/or modify
 # it under the terms of the GNU General Public License version 3 as
 # published by the Free Software Foundation.
 #
 # Adblock Plus is distributed in the hope that it will be useful,
 # but WITHOUT ANY WARRANTY; without even the implied warranty of
 # MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE.  See the
@@ skipping 16 matching lines @@
 
 class Source:
     def resolve_link(self, url, locale):
         parsed = urlparse.urlparse(url)
         page = parsed.path
         if parsed.scheme != '' or page.startswith('/') or page.startswith('.'):
             # Not a page link
             return None, None
 
         if url.startswith('tel:'):
-            # Workaround for 'tel' scheme not recognized on some platforms.

[Sebastian Noack, 2017/02/24 14:32:08]

If this is related to the Python version, as you said, then this comment should
clarify that. So that we don't forget to remove this code, once we no longer
need to support Python 2, and strip out legacy code.

Also, there should probably be a regression test.

[Vasily Kuznetsov, 2017/02/24 16:48:09]

Done.
As we discussed over IRC, the test would not be useful since on Python >2.7.3
the workaround would not run and it's unlikely that developers will run the
tests on older versions of Python.

+            # Workaround for 'tel' scheme not recognized in Python <=2.7.3.
             return None, None
 
         if page == '' and url != '':
             # Page-relative link
             return None, None
 
         config = self.read_config()
         default_locale = config.get('general', 'defaultlocale')
         default_page = config.get('general', 'defaultpage')
         alternative_page = '/'.join([page.rstrip('/'), default_page]).lstrip('/')
@@ skipping 248 matching lines @@
                 path = os.path.join(dir, filename)
                 if os.path.isfile(path):
                     result.append(relpath + filename)
                 elif os.path.isdir(path):
                     do_list(path, relpath + filename + '/')
         do_list(self.get_path(subdir), '')
         return result
 
     def get_cache_dir(self):
         return os.path.join(self._dir, 'cache')