Noissue - Adding support for tel link scheme in Source.resolve_link of CMS

cms/sources.py

Index: cms/sources.py
===================================================================
--- a/cms/sources.py
+++ b/cms/sources.py
@@ -24,17 +24,18 @@
 import zipfile
 import logging
 
 
 class Source:
     def resolve_link(self, url, locale):
         parsed = urlparse.urlparse(url)
         page = parsed.path
-        if parsed.scheme != '' or page.startswith('/') or page.startswith('.'):
+        # manually testing tel scheme because it is not recoginzed by urlparse

[Vasily Kuznetsov, 2017/02/23 19:03:29]

I think it would be better to make this special case a separate if statement.
This would avoid uglier line formatting to fit into 80 character limit and also
emphasize that this is a workaround. How about doing something like:

    if url.startswith('tel:'):
        # Workaround for 'tel' scheme that is not recognized on some platforms.
        return None, None

+        if parsed.scheme != '' or url.startswith('tel:') or page.startswith('/') or page.startswith('.'):
             # Not a page link
             return None, None
 
         if page == '' and url != '':
             # Page-relative link
             return None, None
 
         config = self.read_config()