libadblockplus-android/jni/Application.mk - Issue 29377054: Issue 4942 - Failed to build due to "sorry, unimplemented: mangling dotstar_expr"

Keyboard Shortcuts

	File
u :	up to issue
m :	publish + mail comments
M :	edit review message
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line
<Enter> :	respond to / edit current comment
d :	mark current comment as done

	Issue
u :	up to list of issues
m :	publish + mail comments
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue
# :	close issue

	Comment/message editing
<Ctrl> + s or <Ctrl> + Enter :	save comment
<Esc> :	cancel edit

Delta Between Two Patch Sets: libadblockplus-android/jni/Application.mk

Issue 29377054: Issue 4942 - Failed to build due to "sorry, unimplemented: mangling dotstar_expr" (Closed)

Left Patch Set: Created Feb. 28, 2017, 8:48 a.m.

Right Patch Set: using gcc 4.9 Created March 17, 2017, 10:34 a.m.

Left:
Right:

Use n/p to move between diff chunks; N/P to move between comments.

Jump to:

Left: Side by side diff | Download
Right: Side by side diff | Download

LEFT	RIGHT
1 APP_STL := c++_static	1 APP_STL := c++_static

2 APP_CPPFLAGS := -fexceptions	2 APP_CPPFLAGS := -fexceptions

3 APP_ABI := armeabi-v7a x86	3 APP_ABI := armeabi-v7a x86

4 APP_PLATFORM := android-9	4 APP_PLATFORM := android-9

5 NDK_TOOLCHAIN_VERSION := 4.8	5 NDK_TOOLCHAIN_VERSION := 4.9
anton 2017/02/28 08:53:41 we could just use clang but since libadblockplus u we could just use clang but since libadblockplus uses gcc i believe we should prefer gcc 4.8 to clang anton 2017/03/13 10:11:47 BTW i've just found that `clang` is used to build BTW i've just found that `clang` is used to build libadblockplus: https://hg.adblockplus.org/libadblockplus/file/tip/Makefile#l64 what toolchain should we prefer now? diegocarloslima 2017/03/13 14:25:56 Since we're using clang on libadblockplus and gcc Show quoted text On 2017/03/13 10:11:47, anton wrote: > BTW i've just found that `clang` is used to build libadblockplus: > https://hg.adblockplus.org/libadblockplus/file/tip/Makefile#l64 > > what toolchain should we prefer now? Since we're using clang on libadblockplus and gcc is now deprecated, I would go for using clang, but no strong opinion about that sergei 2017/03/13 15:19:23 gcc is deprecated in the recent android NDK but ou Show quoted text On 2017/03/13 14:25:56, diegocarloslima wrote: > On 2017/03/13 10:11:47, anton wrote: > > BTW i've just found that `clang` is used to build libadblockplus: > > https://hg.adblockplus.org/libadblockplus/file/tip/Makefile#l64 > > > > what toolchain should we prefer now? > > Since we're using clang on libadblockplus and gcc is now deprecated, I would go > for using clang, but no strong opinion about that gcc is deprecated in the recent android NDK but our next version of v8 is using gcc when it's built for arm. I would suggest to use the same gcc everywhere for present and switch to clang when it's done in v8. sergei 2017/03/13 15:40:19 BTW, I have just checked: currently v8 is compile BTW, I have just checked: currently v8 is compiled by g++-4.6 for both arm and android-x86, libadblockplus - clang3.4, ndk 10d. The next version of v8 will use g++-4.9 for both arm android-x86, ndk 12b and I plan to use the same g++ for libadblockplus. Does version 4.8 actually work for you currently?
LEFT	RIGHT