Rietveld Code Review Tool
Help | Bug tracker | Discussion group | Source code

Delta Between Two Patch Sets: test/FilterEngine.cpp

Issue 29377064: Issue 4944 - Make creation of FilterEngine asynchronous. (Closed)
Left Patch Set: Created Feb. 28, 2017, 2:21 p.m.
Right Patch Set: rebase and address comments Created March 16, 2017, 3:47 p.m.
Left:
Right:
Use n/p to move between diff chunks; N/P to move between comments.
Jump to:
Left: Side by side diff | Download
Right: Side by side diff | Download
« no previous file with change/comment | « src/FilterEngine.cpp ('k') | test/Notification.cpp » ('j') | no next file with change/comment »
Toggle Intra-line Diffs ('i') | Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
LEFTRIGHT
1 /* 1 /*
2 * This file is part of Adblock Plus <https://adblockplus.org/>, 2 * This file is part of Adblock Plus <https://adblockplus.org/>,
3 * Copyright (C) 2006-2016 Eyeo GmbH 3 * Copyright (C) 2006-2016 Eyeo GmbH
4 * 4 *
5 * Adblock Plus is free software: you can redistribute it and/or modify 5 * Adblock Plus is free software: you can redistribute it and/or modify
6 * it under the terms of the GNU General Public License version 3 as 6 * it under the terms of the GNU General Public License version 3 as
7 * published by the Free Software Foundation. 7 * published by the Free Software Foundation.
8 * 8 *
9 * Adblock Plus is distributed in the hope that it will be useful, 9 * Adblock Plus is distributed in the hope that it will be useful,
10 * but WITHOUT ANY WARRANTY; without even the implied warranty of 10 * but WITHOUT ANY WARRANTY; without even the implied warranty of
(...skipping 600 matching lines...) Expand 10 before | Expand all | Expand 10 after
611 } 611 }
612 ASSERT_NE(nullptr, aaSubscription); 612 ASSERT_NE(nullptr, aaSubscription);
613 ASSERT_NE(nullptr, langSubscription); 613 ASSERT_NE(nullptr, langSubscription);
614 EXPECT_EQ(aaUrl, aaSubscription->GetProperty("url")->AsString()); 614 EXPECT_EQ(aaUrl, aaSubscription->GetProperty("url")->AsString());
615 EXPECT_EQ(langSubscriptionUrl, langSubscription->GetProperty("url")->AsString( )); 615 EXPECT_EQ(langSubscriptionUrl, langSubscription->GetProperty("url")->AsString( ));
616 } 616 }
617 617
618 TEST_F(FilterEngineWithFreshFolder, DisableSubscriptionsAutoSelectOnFirstRun) 618 TEST_F(FilterEngineWithFreshFolder, DisableSubscriptionsAutoSelectOnFirstRun)
619 { 619 {
620 auto jsEngine = createJsEngine(); 620 auto jsEngine = createJsEngine();
621 FilterEngine::CreateParameters createParams; 621 FilterEngine::CreationParameters createParams;
622 createParams.preconfiguredPrefs["first_run_subscription_auto_select"] = jsEngi ne->NewValue(false); 622 createParams.preconfiguredPrefs["first_run_subscription_auto_select"] = jsEngi ne->NewValue(false);
623 auto filterEngine = AdblockPlus::FilterEngine::Create(jsEngine, createParams); 623 auto filterEngine = AdblockPlus::FilterEngine::Create(jsEngine, createParams);
624 const auto subscriptions = filterEngine->GetListedSubscriptions(); 624 const auto subscriptions = filterEngine->GetListedSubscriptions();
625 EXPECT_EQ(0u, subscriptions.size()); 625 EXPECT_EQ(0u, subscriptions.size());
626 } 626 }
LEFTRIGHT

Powered by Google App Engine
This is Rietveld