shell/src/Main.cpp - Issue 29377064: Issue 4944 - Make creation of FilterEngine asynchronous.

Keyboard Shortcuts

	File
u :	up to issue
m :	publish + mail comments
M :	edit review message
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line
<Enter> :	respond to / edit current comment
d :	mark current comment as done

	Issue
u :	up to list of issues
m :	publish + mail comments
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue
# :	close issue

	Comment/message editing
<Ctrl> + s or <Ctrl> + Enter :	save comment
<Esc> :	cancel edit

Unified Diff: shell/src/Main.cpp

Issue 29377064: Issue 4944 - Make creation of FilterEngine asynchronous. (Closed)

Patch Set: rebase and address comments Created March 16, 2017, 3:47 p.m.

Use n/p to move between diff chunks; N/P to move between comments.

Jump to:

Index: shell/src/Main.cpp

diff --git a/shell/src/Main.cpp b/shell/src/Main.cpp

index a846731ff2d7c5d8c54cd7544d41ccc494e1f44b..ccbbce8f3931b8a334c326eb9f59e0d3f789da6d 100644

--- a/shell/src/Main.cpp

+++ b/shell/src/Main.cpp

@@ -62,15 +62,15 @@ int main()

appInfo.applicationVersion = "1.0";

appInfo.locale = "en-US";

AdblockPlus::JsEnginePtr jsEngine(AdblockPlus::JsEngine::New(appInfo));

- AdblockPlus::FilterEngine filterEngine(jsEngine);

+ auto filterEngine = AdblockPlus::FilterEngine::Create(jsEngine);

CommandMap commands;

Add(commands, new GcCommand(jsEngine));

Add(commands, new HelpCommand(commands));

- Add(commands, new FiltersCommand(filterEngine));

- Add(commands, new SubscriptionsCommand(filterEngine));

- Add(commands, new MatchesCommand(filterEngine));

- Add(commands, new PrefsCommand(filterEngine));

+ Add(commands, new FiltersCommand(*filterEngine));

+ Add(commands, new SubscriptionsCommand(*filterEngine));

+ Add(commands, new MatchesCommand(*filterEngine));

+ Add(commands, new PrefsCommand(*filterEngine));

std::string commandLine;

while (ReadCommandLine(commandLine))

« no previous file with comments | « include/AdblockPlus/FilterEngine.h ('k') | src/FilterEngine.cpp » ('j') | no next file with comments »