Rietveld Code Review Tool
Help | Bug tracker | Discussion group | Source code

Issue 29377951: Issue 4956 - Fix test_runner.js (Closed)

Created:
March 6, 2017, 9:09 p.m. by hub
Modified:
March 16, 2017, 5:11 p.m.
Base URL:
https://hg.adblockplus.org/adblockpluscore
Visibility:
Public.

Description

Issue 4956 - Fix test_runner.js

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+1 line, -1 line) Patch
M test_runner.js View 1 chunk +1 line, -1 line 0 comments Download

Messages

Total messages: 5
hub
March 6, 2017, 9:09 p.m. (2017-03-06 21:09:57 UTC) #1
Felix Dahlke
LGTM Simple enough fix, so I've moved Wladimir to CC.
March 7, 2017, 7:26 a.m. (2017-03-07 07:26:11 UTC) #2
Wladimir Palant
Weird, I wonder how this was working. LGTM How come I didn't get any mail ...
March 7, 2017, 10:34 a.m. (2017-03-07 10:34:00 UTC) #3
Felix Dahlke
On 2017/03/07 10:34:00, Wladimir Palant wrote: > Weird, I wonder how this was working. LGTM ...
March 7, 2017, 11:13 a.m. (2017-03-07 11:13:43 UTC) #4
hub
March 7, 2017, 1:44 p.m. (2017-03-07 13:44:54 UTC) #5
On 2017/03/07 11:13:43, Felix Dahlke wrote:

> Looks like Hubert added you as a reviewer after the initial message. (@Hubert:
> Rietveld never sends emails unless you hit "Publish+Mail Comments")

I'll be careful. Yes I forgot Wladimir at first.

Powered by Google App Engine
This is Rietveld