Issue 4962 - Fix the tests.- Fix syntax in chrome/content/elemHideEmulation.js to use ES5Regress…

test/browser/elemHideEmulation.js

 /*
  * This file is part of Adblock Plus <https://adblockplus.org/>,
  * Copyright (C) 2006-2017 Eyeo GmbH
  *
  * Adblock Plus is free software: you can redistribute it and/or modify
  * it under the terms of the GNU General Public License version 3 as
  * published by the Free Software Foundation.
  *
  * Adblock Plus is distributed in the hope that it will be useful,
  * but WITHOUT ANY WARRANTY; without even the implied warranty of
@@ skipping 111 matching lines @@
     },
     function(selectors)
     {
       if (!selectors.length)
         return;
       var selector = selectors.join(", ");
       insertStyleRule(selector + "{display: none !important;}");
     }
   );
 
-  elemHideEmulation.load(function()
-  {
-    elemHideEmulation.apply();
-    callback();
-  });
+  elemHideEmulation.apply();
+  callback();

[Wladimir Palant, 2017/03/08 10:31:50]

I'm undecided between simplifying the unit test (remove the callback parameter
and just call this function in a synchronous fashion) and leaving things as they
are (could ElemHideEmulation possibly become async again in future?).

[hub, 2017/03/08 13:34:21]

My take was to avoid logic changes to fix the test because I need passing tests
to move onto the issue I'm working on.

[Felix Dahlke, 2017/03/08 20:35:49]

No strong opinion, but I think we should simplify this while at it - it's not a
big change and it just doesn't make sense to have the callback parameter now.
Picturing myself reading this in a year from now, I see myself scratching my
head over what the purpose is.

[hub, 2017/03/08 20:39:48]

I can make that part of bug #3143 since there will be some rework done anyway.

[Felix Dahlke, 2017/03/08 21:44:56]

Fine by me.

 }
 
 exports.testVerbatimPropertySelector = function(test)
 {
   var toHide = createElementWithStyle("{background-color: #000}");
   applyElemHideEmulation(
     ["[-abp-properties='background-color: rgb(0, 0, 0)']"],
     function()
     {
       expectHidden(test, toHide);
@@ skipping 64 matching lines @@
       expectVisible(test, toHide);
       insertStyleRule("#" + toHide.id + " {background-color: #000}");
       window.setTimeout(function()
       {
         expectHidden(test, toHide);
         test.done();
       }, 0);
     }
   );
 };