Rietveld Code Review Tool
Help | Bug tracker | Discussion group | Source code

Unified Diff: test/browser/elemHideEmulation.js

Issue 29378674: Issue 4962 - Fix the tests.- Fix syntax in chrome/content/elemHideEmulation.js to use ES5Regress… (Closed) Base URL: https://hg.adblockplus.org/adblockpluscore
Patch Set: formatting fixes Created March 8, 2017, 12:42 a.m.
Use n/p to move between diff chunks; N/P to move between comments.
Jump to:
View side-by-side diff with in-line comments
Download patch
« chrome/content/elemHideEmulation.js ('K') | « chrome/content/elemHideEmulation.js ('k') | no next file » | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: test/browser/elemHideEmulation.js
===================================================================
--- a/test/browser/elemHideEmulation.js
+++ b/test/browser/elemHideEmulation.js
@@ -124,21 +124,18 @@ function applyElemHideEmulation(selector
{
if (!selectors.length)
return;
var selector = selectors.join(", ");
insertStyleRule(selector + "{display: none !important;}");
}
);
- elemHideEmulation.load(function()
- {
- elemHideEmulation.apply();
- callback();
- });
+ elemHideEmulation.apply();
+ callback();
Wladimir Palant 2017/03/08 10:31:50 I'm undecided between simplifying the unit test (r
hub 2017/03/08 13:34:21 My take was to avoid logic changes to fix the test
Felix Dahlke 2017/03/08 20:35:49 No strong opinion, but I think we should simplify
hub 2017/03/08 20:39:48 I can make that part of bug #3143 since there will
Felix Dahlke 2017/03/08 21:44:56 Fine by me.
}
exports.testVerbatimPropertySelector = function(test)
{
var toHide = createElementWithStyle("{background-color: #000}");
applyElemHideEmulation(
["[-abp-properties='background-color: rgb(0, 0, 0)']"],
function()
« chrome/content/elemHideEmulation.js ('K') | « chrome/content/elemHideEmulation.js ('k') | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld