Rietveld Code Review Tool
Help | Bug tracker | Discussion group | Source code

Issue 29378831: Issue 4953 - Ensure website isn't whitelisted before injecting CSP (Closed)

Created:
March 8, 2017, 1:40 p.m. by kzar
Modified:
March 22, 2017, 6:48 a.m.
Reviewers:
Wladimir Palant
CC:
Sebastian Noack
Visibility:
Public.

Description

Issue 4953 - Ensure website isn't whitelisted before injecting CSP The verdict's out if this is worth it.

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+4 lines, -1 line) Patch
M lib/csp.js View 1 chunk +4 lines, -1 line 0 comments Download

Messages

Total messages: 3
kzar
Patch Set 1
March 8, 2017, 1:42 p.m. (2017-03-08 13:42:11 UTC) #1
Wladimir Palant
LGTM Yes, we definitely shouldn't mess with whitelisted pages.
March 9, 2017, 9:29 a.m. (2017-03-09 09:29:59 UTC) #2
kzar
March 9, 2017, 9:49 a.m. (2017-03-09 09:49:54 UTC) #3
On 2017/03/09 09:29:59, Wladimir Palant wrote:
> LGTM
> 
> Yes, we definitely shouldn't mess with whitelisted pages.

OK, I will push this after the release.

Powered by Google App Engine
This is Rietveld