Rietveld Code Review Tool
Help | Bug tracker | Discussion group | Source code

Issue 29378979: Ticket70 - Remove duplicate/unnecessary logrotate cron job (Closed)

Created:
March 8, 2017, 11:46 p.m. by f.lopez
Modified:
March 9, 2017, 7:44 p.m.
Reviewers:
f.nicolaisen
CC:
mathias, Fred
Visibility:
Public.

Description

Ticket70 - Remove duplicate/unnecessary logrotate cron job

Patch Set 1 #

Total comments: 1

Patch Set 2 : For comment 2 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+2 lines, -8 lines) Patch
M modules/adblockplus/templates/crontab.erb View 1 chunk +1 line, -1 line 0 comments Download
M modules/logrotate/manifests/init.pp View 1 1 chunk +1 line, -7 lines 0 comments Download

Messages

Total messages: 4
f.lopez
March 8, 2017, 11:46 p.m. (2017-03-08 23:46:14 UTC) #1
f.nicolaisen
https://codereview.adblockplus.org/29378979/diff/29378980/modules/logrotate/manifests/init.pp File modules/logrotate/manifests/init.pp (left): https://codereview.adblockplus.org/29378979/diff/29378980/modules/logrotate/manifests/init.pp#oldcode9 modules/logrotate/manifests/init.pp:9: ensure => present, What about ensuring that the cronjob ...
March 9, 2017, 8:53 a.m. (2017-03-09 08:53:19 UTC) #2
f.lopez
March 9, 2017, 4:44 p.m. (2017-03-09 16:44:28 UTC) #3
f.nicolaisen
March 9, 2017, 4:46 p.m. (2017-03-09 16:46:12 UTC) #4
LGTM

Powered by Google App Engine
This is Rietveld