Issue 4968 - Fix messageResponder syntax, declaring functions inside a block not allowed in strict …

messageResponder.js

 /*
  * This file is part of Adblock Plus <https://adblockplus.org/>,
  * Copyright (C) 2006-2016 Eyeo GmbH
  *
  * Adblock Plus is free software: you can redistribute it and/or modify
  * it under the terms of the GNU General Public License version 3 as
  * published by the Free Software Foundation.
  *
  * Adblock Plus is distributed in the hope that it will be useful,
  * but WITHOUT ANY WARRANTY; without even the implied warranty of
  * MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE.  See the
  * GNU General Public License for more details.
  *
  * You should have received a copy of the GNU General Public License
  * along with Adblock Plus.  If not, see <http://www.gnu.org/licenses/>.
  */
 
 "use strict";
 
+(function(global)

[kzar, 2017/03/10 13:42:33]

Why pass `this` as the `global` instead of referring to `window` directly?

[Wladimir Palant, 2017/03/12 08:16:18]

Because that's assumptions about the global object. In browser context the
global object can be referred to via global window variable. In other contexts
this variable doesn't exist. In particular, when this runs in Firefox window
will be undefined.

[kzar, 2017/03/13 07:47:24]

Acknowledged.

 {
-  var ext = ext || require("ext_background");
+  let ext = global.ext || require("ext_background");
 
   const {port} = require("messaging");
   const {Prefs} = require("prefs");
   const {Utils} = require("utils");
   const {FilterStorage} = require("filterStorage");
   const {FilterNotifier} = require("filterNotifier");
   const {defaultMatcher} = require("matcher");
   const {ElemHideEmulation} = require("elemHideEmulation");
   const {Notification: NotificationStorage} = require("notification");
 
@@ skipping 385 matching lines @@
   port.on("subscriptions.update", (message, sender) =>
   {
     let subscriptions = message.url ? [Subscription.fromURL(message.url)] :
                         FilterStorage.subscriptions;
     for (let subscription of subscriptions)
     {
       if (subscription instanceof DownloadableSubscription)
         Synchronizer.execute(subscription, true);
     }
   });
-}
+})(this);