Rietveld Code Review Tool
Help | Bug tracker | Discussion group | Source code

Issue 29380555: Noissue - undo accidental logic changes introduced by 78d85c096f9e (Closed)

Created:
March 11, 2017, 4:58 p.m. by Vasily Kuznetsov
Modified:
March 14, 2017, 8:30 p.m.
Visibility:
Public.

Description

Noissue - undo accidental logic changes introduced by 78d85c096f9e Repository: https://hg.adblockplus.org/cms Base revision: 8f0abb31be39 COLLABORATOR=jon@adblockplus.org

Patch Set 1 #

Total comments: 4

Patch Set 2 : Address review feedback on patch set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+14 lines, -12 lines) Patch
M cms/converters.py View 1 6 chunks +13 lines, -11 lines 0 comments Download
M tox.ini View 1 1 chunk +1 line, -1 line 0 comments Download

Messages

Total messages: 7
Vasily Kuznetsov
Hi Jon! I looked at what needs to be done to fix the CMS bugs ...
March 11, 2017, 5:03 p.m. (2017-03-11 17:03:12 UTC) #1
Vasily Kuznetsov
P.S. I added 'from __future__ import unicode_literals' at the top -- it was needed to ...
March 11, 2017, 5:08 p.m. (2017-03-11 17:08:05 UTC) #2
Vasily Kuznetsov
Hi Wladimir, Jon and I have thought that you might also want to comment on ...
March 12, 2017, 12:18 p.m. (2017-03-12 12:18:54 UTC) #3
Wladimir Palant
Wow, that's a remarkable number of regressions for a single style-only change. Feel free to ...
March 12, 2017, 4:02 p.m. (2017-03-12 16:02:22 UTC) #4
Vasily Kuznetsov
> Wow, that's a remarkable number of regressions for a single style-only change. > Feel ...
March 13, 2017, 12:25 p.m. (2017-03-13 12:25:29 UTC) #5
Wladimir Palant
LGTM
March 13, 2017, 1:43 p.m. (2017-03-13 13:43:55 UTC) #6
Jon Sonesen
March 13, 2017, 2:16 p.m. (2017-03-13 14:16:45 UTC) #7
On 2017/03/13 13:43:55, Wladimir Palant wrote:
> LGTM

LGTM

Powered by Google App Engine
This is Rietveld