Issue 4977 - Request for compressed response in AndroidWebRequest

libadblockplus-android/src/org/adblockplus/libadblockplus/android/AndroidWebRequest.java

 /*
  * This file is part of Adblock Plus <https://adblockplus.org/>,
  * Copyright (C) 2006-2016 Eyeo GmbH
  *
  * Adblock Plus is free software: you can redistribute it and/or modify
  * it under the terms of the GNU General Public License version 3 as
  * published by the Free Software Foundation.
  *
  * Adblock Plus is distributed in the hope that it will be useful,
  * but WITHOUT ANY WARRANTY; without even the implied warranty of
@@ skipping 33 matching lines @@
 
   public final static String TAG = Utils.getTag(WebRequest.class);
 
   private final HashSet<String> subscriptionURLs = new HashSet<String>();
   private final boolean elemhideEnabled;
   private final boolean compressedStream;
 
   /**
    * Ctor
    * @param enableElemhide Enable element hiding?
-   *                       Element hiding required significantly more memory

[diegocarloslima, 2017/03/16 19:49:23]

I would change here to 'Element hiding requires...'

[anton, 2017/03/17 05:54:44]

Acknowledged.

-   *                       but allows to apply element hiding for better ad blocking

[diegocarloslima, 2017/03/16 19:49:23]

I would shorten here to 'but allows better ad blocking'

[anton, 2017/03/17 05:54:44]

Acknowledged.

+   *                       Element hiding requires significantly more memory
+   *                       but allows better ad blocking
    * @param compressedStream Request for gzip compressed stream from the server
    */
   public AndroidWebRequest(boolean enableElemhide, boolean compressedStream)
   {
     this.elemhideEnabled = enableElemhide;
     this.compressedStream = compressedStream;
   }
 
   public AndroidWebRequest()
   {
     this(false, true);

[anton, 2017/03/13 07:03:34]

i believe we should apply gzipping by default.

   }
 
   private boolean isListedSubscriptionUrl(final URL url)
   {
     String toCheck = url.toString();
 
     final int idx = toCheck.indexOf('?');
     if (idx != -1)
     {
       toCheck = toCheck.substring(0, idx);
@@ skipping 14 matching lines @@
   @Override
   public ServerResponse httpGET(final String urlStr, final List<HeaderEntry> headers)
   {
     try
     {
       final URL url = new URL(urlStr);
       Log.d(TAG, "Downloading from: " + url);
 
       final HttpURLConnection connection = (HttpURLConnection) url.openConnection();
       connection.setRequestMethod("GET");
       connection.setRequestProperty("Accept-Encoding",

[anton, 2017/03/13 07:03:34]

requesting for gzipping is expected to be done by android behind the scene but
it's not applied for https.
i believe we should add the request header explicitly not to depend on default
behaviour.

         (compressedStream ? ENCODING_GZIP : ENCODING_IDENTITY));
       connection.connect();
 
       final ServerResponse response = new ServerResponse();
       response.setResponseStatus(connection.getResponseCode());
 
       if (response.getResponseStatus() == 200)
       {
         final InputStream inputStream =
           (compressedStream && ENCODING_GZIP.equals(connection.getContentEncoding())
@@ skipping 48 matching lines @@
       Log.d(TAG, "Downloading finished");
       return response;
     }
     catch (final Throwable t)
     {
       Log.e(TAG, "WebRequest failed", t);
       throw new AdblockPlusException("WebRequest failed", t);
     }
   }
 }