Rietveld Code Review Tool
Help | Bug tracker | Discussion group | Source code | Sign in
(95)

Issue 29382567: No issue - change initialiser calls (Closed)

Can't Edit
Can't Publish+Mail
Start Review
Created:
2 years, 11 months ago by hub
Modified:
2 years, 11 months ago
Reviewers:
Felix Dahlke, sergei
Base URL:
https://hg.adblockplus.org/libadblockplus/
Visibility:
Public.

Description

Change initialiser calls

Patch Set 1 #

Total comments: 1

Patch Set 2 : Updated following feedback #

Patch Set 3 : Split out the patch to only fix initialisers #

Patch Set 4 : Updated commit message. #

Unified diffs Side-by-side diffs Delta from patch set Stats (+3 lines, -3 lines) Patch
M test/WebRequest.cpp View 1 2 2 chunks +3 lines, -3 lines 0 comments Download

Messages

Total messages: 4
hub
2 years, 11 months ago (2017-03-13 14:11:12 UTC) #1
sergei
LGTM, however I would rather make two noissue commits, one with initialisers and another one ...
2 years, 11 months ago (2017-03-13 14:33:45 UTC) #2
hub
used auto as per feedback.
2 years, 11 months ago (2017-03-13 14:52:17 UTC) #3
hub
2 years, 11 months ago (2017-03-13 19:27:08 UTC) #4
Only the initializer as per sergei comment on splitting things out. Unless I
misunderstood.
Sign in to reply to this message.

Powered by Google App Engine
RSS Feeds Recent Issues | This issue
This is Rietveld 87257f5