Rietveld Code Review Tool
Help | Bug tracker | Discussion group | Source code

Issue 29382567: No issue - change initialiser calls (Closed)

Created:
March 13, 2017, 2:11 p.m. by hub
Modified:
March 16, 2017, 6:31 p.m.
Reviewers:
sergei, Felix Dahlke
Base URL:
https://hg.adblockplus.org/libadblockplus/
Visibility:
Public.

Description

Change initialiser calls

Patch Set 1 #

Total comments: 1

Patch Set 2 : Updated following feedback #

Patch Set 3 : Split out the patch to only fix initialisers #

Patch Set 4 : Updated commit message. #

Unified diffs Side-by-side diffs Delta from patch set Stats (+3 lines, -3 lines) Patch
M test/WebRequest.cpp View 1 2 2 chunks +3 lines, -3 lines 0 comments Download

Messages

Total messages: 4
hub
March 13, 2017, 2:11 p.m. (2017-03-13 14:11:12 UTC) #1
sergei
LGTM, however I would rather make two noissue commits, one with initialisers and another one ...
March 13, 2017, 2:33 p.m. (2017-03-13 14:33:45 UTC) #2
hub
used auto as per feedback.
March 13, 2017, 2:52 p.m. (2017-03-13 14:52:17 UTC) #3
hub
March 13, 2017, 7:27 p.m. (2017-03-13 19:27:08 UTC) #4
Only the initializer as per sergei comment on splitting things out. Unless I
misunderstood.

Powered by Google App Engine
This is Rietveld