Issue 3143 - Filter elements with :-abp-has()

lib/filterClasses.js

 /*
  * This file is part of Adblock Plus <https://adblockplus.org/>,
  * Copyright (C) 2006-2017 eyeo GmbH
  *
  * Adblock Plus is free software: you can redistribute it and/or modify
  * it under the terms of the GNU General Public License version 3 as
  * published by the Free Software Foundation.
  *
  * Adblock Plus is distributed in the hope that it will be useful,
  * but WITHOUT ANY WARRANTY; without even the implied warranty of
@@ skipping 969 matching lines @@
 
   // We don't allow ElemHide filters which have any empty domains.
   // Note: The ElemHide.prototype.domainSeparator is duplicated here, if that
   // changes this must be changed too.
   if (domain && /(^|,)~?(,|$)/.test(domain))
     return new InvalidFilter(text, "filter_invalid_domain");
 
   if (isException)
     return new ElemHideException(text, domain, selector);
 
-  if (selector.indexOf("[-abp-properties=") != -1)
+  if ((selector.indexOf("[-abp-properties=") != -1) ||
+      (selector.indexOf("[-abp-selector=") != -1))
   {
     // Element hiding emulation filters are inefficient so we need to make sure
     // that they're only applied if they specify active domains
     if (!/,[^~][^,.]*\.[^,]/.test("," + domain))
       return new InvalidFilter(text, "filter_elemhideemulation_nodomain");
 
     return new ElemHideEmulationFilter(text, domain, selector);
   }
 
   return new ElemHideFilter(text, domain, selector);
@@ skipping 39 matching lines @@
  * Class for element hiding emulation filters
  * @param {string} text           see Filter()
  * @param {string} domains        see ElemHideBase()
  * @param {string} selector       see ElemHideBase()
  * @constructor
  * @augments ElemHideBase
  */
 function ElemHideEmulationFilter(text, domains, selector)
 {
   ElemHideBase.call(this, text, domains, selector);
+  this.cssPropFilter = (selector.indexOf("[-abp-properties=") != -1);
+  this.abpSelectorFilter = (selector.indexOf("[-abp-selector=") != -1);

[Felix Dahlke, 2017/04/10 10:55:12]

When I first renamed CSS property filters to element hiding emulation filters, I
also wanted to introduce flags for what kind of features are going to be
emulated. However, we concluded that this is just unused code with no real
benefit, see the old discussion here:
https://codereview.adblockplus.org/29361668/diff/29361669/lib/filterClasses.j...

[hub, 2017/04/10 12:29:27]

They are unused here too. I just shall remove them. I think they are leftover
from code that got removed.

 }
 exports.ElemHideEmulationFilter = ElemHideEmulationFilter;
 
 ElemHideEmulationFilter.prototype = extend(ElemHideBase, {
-  type: "elemhideemulation"
+  type: "elemhideemulation",
+  cssPropFilter: false,
+  abpSelectorFilter: false
 });