Delta Between Two Patch Sets: chrome/content/.eslintrc.json 
  
    
  
    
      
	 
    
  
 
    Issue 29383960 : 
  Issue 3143 - Filter elements with :-abp-has()  (Closed) 
  
 
  
    Left Patch Set: Linter pass 
    
  
  
    Right Patch Set: Fix reportError and the error message 
    
  
  
    
      
        Left: 
        
          
            Base 
            
            Patch Set 1: None 
            
            Patch Set 2: Linter pass 
            
            Patch Set 3: Hide elements and not using styles. 
            
            Patch Set 4: Fixed several bugs. Cleanup code. 
            
            Patch Set 5: Support -adb-properties inside :has(). 
            
            Patch Set 6: More cleanup, more robust tests 
            
            Patch Set 7: :has(:has()) do work now. All test pass. 
            
            Patch Set 8: Updated patch following feedback. 
            
            Patch Set 9: Lots of cleanup. Simpler, better. 
            
            Patch Set 10: Updated the filter syntax 
            
            Patch Set 11: Validate the syntax, remove unused flags 
            
            Patch Set 12: Moved unwrap to filterClass, ES6 syntax, use :-abp-has(), don't modify DOM to select, rebased on 29… 
            
            Patch Set 13: Reworked the pseudo class to generate selectors. 
            
            Patch Set 14: Non regexp based parser. 
            
            Patch Set 15: Now we properly upgrade to the new syntax for [-abp-properties=] 
            
            Patch Set 16: Filter reporting was broken in the previous revision. 
            
            Patch Set 17: Added validate of element id, and fixed an infinite recursion in parsing. 
            
            Patch Set 18: Reworked patch following the feedback 
            
            Patch Set 19: Remove unused getElements for PlainSelector and PropsSelector. 
            
            Patch Set 20: Rebased on master. Handled all the feedback. 
            
            Patch Set 21: Addressed the comments. 
            
            Patch Set 22: Address the last comment 
            
            Patch Set 23: Last comments. 
            
            Patch Set 24: Revised patch 
            
            Patch Set 25: One non code change was missing. 
            
            Patch Set 26: Make sure we run without expecting browser environment. 
            
            Patch Set 27: Fix reportError and the error message 
            
           
         
         
      
        Right: 
        
          
            
            Patch Set 1: None 
            
            Patch Set 2: Linter pass 
            
            Patch Set 3: Hide elements and not using styles. 
            
            Patch Set 4: Fixed several bugs. Cleanup code. 
            
            Patch Set 5: Support -adb-properties inside :has(). 
            
            Patch Set 6: More cleanup, more robust tests 
            
            Patch Set 7: :has(:has()) do work now. All test pass. 
            
            Patch Set 8: Updated patch following feedback. 
            
            Patch Set 9: Lots of cleanup. Simpler, better. 
            
            Patch Set 10: Updated the filter syntax 
            
            Patch Set 11: Validate the syntax, remove unused flags 
            
            Patch Set 12: Moved unwrap to filterClass, ES6 syntax, use :-abp-has(), don't modify DOM to select, rebased on 29… 
            
            Patch Set 13: Reworked the pseudo class to generate selectors. 
            
            Patch Set 14: Non regexp based parser. 
            
            Patch Set 15: Now we properly upgrade to the new syntax for [-abp-properties=] 
            
            Patch Set 16: Filter reporting was broken in the previous revision. 
            
            Patch Set 17: Added validate of element id, and fixed an infinite recursion in parsing. 
            
            Patch Set 18: Reworked patch following the feedback 
            
            Patch Set 19: Remove unused getElements for PlainSelector and PropsSelector. 
            
            Patch Set 20: Rebased on master. Handled all the feedback. 
            
            Patch Set 21: Addressed the comments. 
            
            Patch Set 22: Address the last comment 
            
            Patch Set 23: Last comments. 
            
            Patch Set 24: Revised patch 
            
            Patch Set 25: One non code change was missing. 
            
            Patch Set 26: Make sure we run without expecting browser environment. 
            
            Patch Set 27: Fix reportError and the error message 
            
           
         
       
    
   
  
    Use n/p to move between diff chunks;
    N/P to move between comments.