Rietveld Code Review Tool
Help | Bug tracker | Discussion group | Source code

Delta Between Two Patch Sets: chrome/content/elemHideEmulation.js

Issue 29383960: Issue 3143 - Filter elements with :-abp-has() (Closed) Base URL: https://hg.adblockplus.org/adblockpluscore
Left Patch Set: Fixed several bugs. Cleanup code. Created March 17, 2017, 1:25 a.m.
Right Patch Set: Fix reportError and the error message Created June 13, 2017, 1:52 p.m.
Left:
Right:
Use n/p to move between diff chunks; N/P to move between comments.
Jump to:
Left: Side by side diff | Download
Right: Side by side diff | Download
« no previous file with change/comment | « chrome/content/.eslintrc.json ('k') | test/browser/elemHideEmulation.js » ('j') | no next file with change/comment »
Toggle Intra-line Diffs ('i') | Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
LEFTRIGHT
1 // We are currently limited to ECMAScript 5 in this file, because it is being 1 /*
2 // used in the browser tests. See https://issues.adblockplus.org/ticket/4796 2 * This file is part of Adblock Plus <https://adblockplus.org/>,
3 3 * Copyright (C) 2006-2017 eyeo GmbH
4 var propertySelectorRegExp = /\[\-abp\-properties=(["'])([^"']+)\1\]/; 4 *
5 var pseudoClassHasSelectorRegExp = /:has\((.*)\)/; 5 * Adblock Plus is free software: you can redistribute it and/or modify
6 * it under the terms of the GNU General Public License version 3 as
7 * published by the Free Software Foundation.
8 *
9 * Adblock Plus is distributed in the hope that it will be useful,
10 * but WITHOUT ANY WARRANTY; without even the implied warranty of
11 * MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE. See the
12 * GNU General Public License for more details.
13 *
14 * You should have received a copy of the GNU General Public License
15 * along with Adblock Plus. If not, see <http://www.gnu.org/licenses/>.
16 */
17
18 /* globals filterToRegExp */
19
20 "use strict";
21
22 const abpSelectorRegexp = /:-abp-([\w-]+)\(/i;
23
24 let reportError = () => {};
6 25
7 function splitSelector(selector) 26 function splitSelector(selector)
8 { 27 {
9 if (selector.indexOf(",") == -1) 28 if (selector.indexOf(",") == -1)
10 return [selector]; 29 return [selector];
11 30
12 var selectors = []; 31 let selectors = [];
13 var start = 0; 32 let start = 0;
14 var level = 0; 33 let level = 0;
15 var sep = ""; 34 let sep = "";
16 35
17 for (var i = 0; i < selector.length; i++) 36 for (let i = 0; i < selector.length; i++)
18 { 37 {
19 var chr = selector[i]; 38 let chr = selector[i];
20 39
21 if (chr == "\\") // ignore escaped characters 40 if (chr == "\\") // ignore escaped characters
22 i++; 41 i++;
23 else if (chr == sep) // don't split within quoted text 42 else if (chr == sep) // don't split within quoted text
24 sep = ""; // e.g. [attr=","] 43 sep = ""; // e.g. [attr=","]
25 else if (sep == "") 44 else if (sep == "")
26 { 45 {
27 if (chr == '"' || chr == "'") 46 if (chr == '"' || chr == "'")
28 sep = chr; 47 sep = chr;
29 else if (chr == "(") // don't split between parentheses 48 else if (chr == "(") // don't split between parentheses
30 level++; // e.g. :matches(div,span) 49 level++; // e.g. :matches(div,span)
31 else if (chr == ")") 50 else if (chr == ")")
32 level = Math.max(0, level - 1); 51 level = Math.max(0, level - 1);
33 else if (chr == "," && level == 0) 52 else if (chr == "," && level == 0)
34 { 53 {
35 selectors.push(selector.substring(start, i)); 54 selectors.push(selector.substring(start, i));
36 start = i + 1; 55 start = i + 1;
37 } 56 }
38 } 57 }
39 } 58 }
40 59
41 selectors.push(selector.substring(start)); 60 selectors.push(selector.substring(start));
42 return selectors; 61 return selectors;
43 } 62 }
44 63
45 // matcher for the pseudo CSS4 class :has 64 /** Return position of node from parent.
46 // For those browser that don't have it yet. 65 * @param {Node} node the node to find the position of.
47 function PseudoHasMatcher(selector) 66 * @return {number} One-based index like for :nth-child(), or 0 on error.
48 { 67 */
49 this.hasSelector = selector; 68 function positionInParent(node)
50 } 69 {
51 70 let {children} = node.parentNode;
52 PseudoHasMatcher.prototype = { 71 for (let i = 0; i < children.length; i++)
53 match: function(elem, firstOnly) 72 if (children[i] == node)
54 { 73 return i + 1;
55 var matches = []; 74 return 0;
56 // look up for all elements that match the :has(). 75 }
57 var children = elem.children; 76
58 for (var i = 0; i < children.length; i++) 77 function makeSelector(node, selector)
59 { 78 {
60 var hasElem = elem.querySelector(this.hasSelector); 79 if (!node.parentElement)
61 if (hasElem != null) 80 {
62 { 81 let newSelector = ":root";
63 matches.push(hasElem); 82 if (selector)
64 if (firstOnly) 83 newSelector += " > " + selector;
65 break; 84 return newSelector;
66 } 85 }
67 } 86 let idx = positionInParent(node);
68 return matches; 87 if (idx > 0)
88 {
89 let newSelector = `${node.tagName}:nth-child(${idx})`;
90 if (selector)
91 newSelector += " > " + selector;
92 return makeSelector(node.parentElement, newSelector);
93 }
94
95 return selector;
96 }
97
98 function parseSelectorContent(content, startIndex)
99 {
100 let parens = 1;
101 let quote = null;
102 let i = startIndex;
103 for (; i < content.length; i++)
104 {
105 let c = content[i];
106 if (c == "\\")
107 {
108 // Ignore escaped characters
109 i++;
110 }
111 else if (quote)
112 {
113 if (c == quote)
114 quote = null;
115 }
116 else if (c == "'" || c == '"')
117 quote = c;
118 else if (c == "(")
119 parens++;
120 else if (c == ")")
121 {
122 parens--;
123 if (parens == 0)
124 break;
125 }
126 }
127
128 if (parens > 0)
129 return null;
130 return {text: content.substring(startIndex, i), end: i};
131 }
132
133 /** Parse the selector
134 * @param {string} selector the selector to parse
135 * @return {Object} selectors is an array of objects,
136 * or null in case of errors. hide is true if we'll hide
137 * elements instead of styles..
138 */
139 function parseSelector(selector)
140 {
141 if (selector.length == 0)
142 return [];
143
144 let match = abpSelectorRegexp.exec(selector);
145 if (!match)
146 return [new PlainSelector(selector)];
147
148 let selectors = [];
149 if (match.index > 0)
150 selectors.push(new PlainSelector(selector.substr(0, match.index)));
151
152 let startIndex = match.index + match[0].length;
153 let content = parseSelectorContent(selector, startIndex);
154 if (!content)
155 {
156 reportError(new SyntaxError("Failed to parse Adblock Plus " +
157 `selector ${selector}, ` +
158 "due to unmatched parentheses."));
159 return null;
160 }
161 if (match[1] == "properties")
162 selectors.push(new PropsSelector(content.text));
163 else if (match[1] == "has")
164 {
165 let hasSelector = new HasSelector(content.text);
166 if (!hasSelector.valid())
167 return null;
168 selectors.push(hasSelector);
169 }
170 else
171 {
172 // this is an error, can't parse selector.
173 reportError(new SyntaxError("Failed to parse Adblock Plus " +
174 `selector ${selector}, invalid ` +
175 `pseudo-class :-abp-${match[1]}().`));
176 return null;
177 }
178
179 let suffix = parseSelector(selector.substr(content.end + 1));
180 if (suffix == null)
181 return null;
182
183 selectors.push(...suffix);
184
185 return selectors;
186 }
187
188 /** Stringified style objects
189 * @typedef {Object} StringifiedStyle
190 * @property {string} style CSS style represented by a string.
191 * @property {string[]} subSelectors selectors the CSS properties apply to.
192 */
193
194 /**
195 * Produce a string representation of the stylesheet entry.
196 * @param {CSSStyleRule} rule the CSS style rule.
197 * @return {StringifiedStyle} the stringified style.
198 */
199 function stringifyStyle(rule)
200 {
201 let styles = [];
202 for (let i = 0; i < rule.style.length; i++)
203 {
204 let property = rule.style.item(i);
205 let value = rule.style.getPropertyValue(property);
206 let priority = rule.style.getPropertyPriority(property);
207 styles.push(`${property}: ${value}${priority ? " !" + priority : ""};`);
208 }
209 styles.sort();
210 return {
211 style: styles.join(" "),
212 subSelectors: splitSelector(rule.selectorText)
213 };
214 }
215
216 function* evaluate(chain, index, prefix, subtree, styles)
217 {
218 if (index >= chain.length)
219 {
220 yield prefix;
221 return;
222 }
223 for (let [selector, element] of
224 chain[index].getSelectors(prefix, subtree, styles))
225 yield* evaluate(chain, index + 1, selector, element, styles);
226 }
227
228 function PlainSelector(selector)
229 {
230 this._selector = selector;
231 }
232
233 PlainSelector.prototype = {
234 /**
235 * Generator function returning a pair of selector
236 * string and subtree.
237 * @param {string} prefix the prefix for the selector.
238 * @param {Node} subtree the subtree we work on.
239 * @param {StringifiedStyle[]} styles the stringified style objects.
240 */
241 *getSelectors(prefix, subtree, styles)
242 {
243 yield [prefix + this._selector, subtree];
69 } 244 }
70 }; 245 };
71 246
72 function ElemHideEmulation(window, getFiltersFunc, addSelectorsFunc, hideElement sFunc) 247 const incompletePrefixRegexp = /[\s>+~]$/;
248
249 function HasSelector(selector)
250 {
251 this._innerSelectors = parseSelector(selector);
252 }
253
254 HasSelector.prototype = {
255 requiresHiding: true,
256
257 valid()
258 {
259 return this._innerSelectors != null;
260 },
261
262 *getSelectors(prefix, subtree, styles)
263 {
264 for (let element of this.getElements(prefix, subtree, styles))
265 yield [makeSelector(element, ""), element];
266 },
267
268 /**
269 * Generator function returning selected elements.
270 * @param {string} prefix the prefix for the selector.
271 * @param {Node} subtree the subtree we work on.
272 * @param {StringifiedStyle[]} styles the stringified style objects.
273 */
274 *getElements(prefix, subtree, styles)
275 {
276 let actualPrefix = (!prefix || incompletePrefixRegexp.test(prefix)) ?
277 prefix + "*" : prefix;
278 let elements = subtree.querySelectorAll(actualPrefix);
279 for (let element of elements)
280 {
281 let newPrefix = makeSelector(element, "");
282 let iter = evaluate(this._innerSelectors, 0, newPrefix + " ",
283 element, styles);
284 for (let selector of iter)
285 // we insert a space between the two. It becomes a no-op if selector
286 // doesn't have a combinator
287 if (subtree.querySelector(selector))
288 yield element;
289 }
290 }
291 };
292
293 function PropsSelector(propertyExpression)
294 {
295 let regexpString;
296 if (propertyExpression.length >= 2 && propertyExpression[0] == "/" &&
297 propertyExpression[propertyExpression.length - 1] == "/")
298 {
299 regexpString = propertyExpression.slice(1, -1)
300 .replace("\\x7B ", "{").replace("\\x7D ", "}");
301 }
302 else
303 regexpString = filterToRegExp(propertyExpression);
304
305 this._regexp = new RegExp(regexpString, "i");
306 }
307
308 PropsSelector.prototype = {
309 *findPropsSelectors(styles, prefix, regexp)
310 {
311 for (let style of styles)
312 if (regexp.test(style.style))
313 for (let subSelector of style.subSelectors)
314 yield prefix + subSelector;
315 },
316
317 *getSelectors(prefix, subtree, styles)
318 {
319 for (let selector of this.findPropsSelectors(styles, prefix, this._regexp))
320 yield [selector, subtree];
321 }
322 };
323
324 function ElemHideEmulation(window, getFiltersFunc, addSelectorsFunc,
325 hideElemsFunc)
73 { 326 {
74 this.window = window; 327 this.window = window;
75 this.getFiltersFunc = getFiltersFunc; 328 this.getFiltersFunc = getFiltersFunc;
76 this.addSelectorsFunc = addSelectorsFunc; 329 this.addSelectorsFunc = addSelectorsFunc;
77 this.hideElementsFunc = hideElementsFunc; 330 this.hideElemsFunc = hideElemsFunc;
78 } 331 }
79 332
80 ElemHideEmulation.prototype = { 333 ElemHideEmulation.prototype = {
81 stringifyStyle: function(style) 334 isSameOrigin(stylesheet)
82 {
83 var styles = [];
84 for (var i = 0; i < style.length; i++)
85 {
86 var property = style.item(i);
87 var value = style.getPropertyValue(property);
88 var priority = style.getPropertyPriority(property);
89 styles.push(property + ": " + value + (priority ? " !" + priority : "") + ";");
90 }
91 styles.sort();
92 return styles.join(" ");
93 },
94
95 isSameOrigin: function(stylesheet)
96 { 335 {
97 try 336 try
98 { 337 {
99 return new URL(stylesheet.href).origin == this.window.location.origin; 338 return new URL(stylesheet.href).origin == this.window.location.origin;
100 } 339 }
101 catch (e) 340 catch (e)
102 { 341 {
103 // Invalid URL, assume that it is first-party. 342 // Invalid URL, assume that it is first-party.
104 return true; 343 return true;
105 } 344 }
106 }, 345 },
107 346
108 findSelectors: function(stylesheet, selectors, filters) 347 addSelectors(stylesheets)
109 { 348 {
110 // Explicitly ignore third-party stylesheets to ensure consistent behavior 349 let selectors = [];
111 // between Firefox and Chrome. 350 let selectorFilters = [];
112 if (!this.isSameOrigin(stylesheet)) 351
113 return; 352 let elements = [];
114 353 let elementFilters = [];
115 var rules = stylesheet.cssRules; 354
116 if (!rules) 355 let cssStyles = [];
117 return; 356
118 357 for (let stylesheet of stylesheets)
119 for (var i = 0; i < rules.length; i++) 358 {
120 { 359 // Explicitly ignore third-party stylesheets to ensure consistent behavior
121 var rule = rules[i]; 360 // between Firefox and Chrome.
122 if (rule.type != rule.STYLE_RULE) 361 if (!this.isSameOrigin(stylesheet))
123 continue; 362 continue;
124 363
125 var style = this.stringifyStyle(rule.style); 364 let rules = stylesheet.cssRules;
126 for (var j = 0; j < this.propSelPatterns.length; j++) 365 if (!rules)
366 continue;
367
368 for (let rule of rules)
127 { 369 {
128 var pattern = this.propSelPatterns[j]; 370 if (rule.type != rule.STYLE_RULE)
129 if (pattern.regexp.test(style)) 371 continue;
372
373 cssStyles.push(stringifyStyle(rule));
374 }
375 }
376
377 let {document} = this.window;
378 for (let pattern of this.patterns)
379 {
380 for (let selector of evaluate(pattern.selectors,
381 0, "", document, cssStyles))
382 {
383 if (!pattern.selectors.some(s => s.requiresHiding))
130 { 384 {
131 var subSelectors = splitSelector(rule.selectorText); 385 selectors.push(selector);
132 for (var k = 0; k < subSelectors.length; k++) 386 selectorFilters.push(pattern.text);
387 }
388 else
389 {
390 for (let element of document.querySelectorAll(selector))
133 { 391 {
134 var subSelector = subSelectors[k]; 392 elements.push(element);
135 selectors.push(pattern.prefix + subSelector + pattern.suffix); 393 elementFilters.push(pattern.text);
136 filters.push(pattern.text);
137 } 394 }
138 } 395 }
139 } 396 }
140 } 397 }
141 }, 398
142 399 this.addSelectorsFunc(selectors, selectorFilters);
143 findPseudoClassHasElements: function(stylesheets, elements, filters) 400 this.hideElemsFunc(elements, elementFilters);
144 { 401 },
145 for (var i = 0; i < this.pseudoHasPatterns.length; i++) 402
146 { 403 onLoad(event)
147 var pattern = this.pseudoHasPatterns[i]; 404 {
148 405 let stylesheet = event.target.sheet;
149 var haveEl = document.querySelectorAll(pattern.prefix);
150 for (var j = 0; j < haveEl.length; j++)
151 {
152 var matched = pattern.elementMatcher.match(haveEl[j], !pattern.suffix);
153 if (matched.length == 0)
154 continue;
155
156 if (pattern.suffix)
157 {
158 matched.forEach(function(e)
159 {
160 var sel = pattern.suffix;
161 // XXX we should have a more elegant way
162 // also startsWith isn't available in PhantomJS.
163 if (sel.substr(0, 1) == ">")
164 sel = sel.substr(1);
165 var subElements = e.querySelectorAll(sel);
166 for (var k = 0; k < subElements.length; k++)
167 {
168 elements.push(subElements[i]);
169 filters.push(pattern.text);
170 }
171 });
172 }
173 else
174 {
175 elements.push(haveEl[j]);
176 filters.push(pattern.text);
177 }
178 }
179 }
180 },
181
182 addSelectors: function(stylesheets)
183 {
184 var selectors = [];
185 var filters = [];
186 for (var i = 0; i < stylesheets.length; i++)
187 this.findSelectors(stylesheets[i], selectors, filters);
188 this.addSelectorsFunc(selectors, filters);
189 },
190
191 hideElements: function(stylesheets)
192 {
193 var elements = [];
194 var filters = [];
195 this.findPseudoClassHasElements(stylesheets, elements, filters);
196 this.hideElementsFunc(elements, filters);
197 },
198
199 onLoad: function(event)
200 {
201 var stylesheet = event.target.sheet;
202 if (stylesheet) 406 if (stylesheet)
203 this.addSelectors([stylesheet]); 407 this.addSelectors([stylesheet]);
204 this.hideElements(); 408 },
205 }, 409
206 410 apply()
207 parsePattern: function(pattern) 411 {
208 { 412 this.getFiltersFunc(patterns =>
209 // we should catch the :has() pseudo class first. 413 {
210 var match = pseudoClassHasSelectorRegExp.exec(pattern.selector); 414 let oldReportError = reportError;
211 if (match) 415 reportError = error => this.window.console.error(error);
212 { 416
213 return { 417 this.patterns = [];
214 type: "has", 418 for (let pattern of patterns)
215 text: pattern.text,
216 elementMatcher: new PseudoHasMatcher(match[1]),
217 prefix: pattern.selector.substr(0, match.index).trim(),
218 suffix: pattern.selector.substr(match.index + match[0].length).trim()
219 };
220 }
221
222 match = propertySelectorRegExp.exec(pattern.selector);
223 if (match)
224 {
225 var regexpString;
226 var propertyExpression = match[2];
227 if (propertyExpression.length >= 2 && propertyExpression[0] == "/" &&
228 propertyExpression[propertyExpression.length - 1] == "/")
229 regexpString = propertyExpression.slice(1, -1)
230 .replace("\\x7B ", "{").replace("\\x7D ", "}");
231 else
232 regexpString = filterToRegExp(propertyExpression);
233 return {
234 type: "props",
235 text: pattern.text,
236 regexp: new RegExp(regexpString, "i"),
237 prefix: pattern.selector.substr(0, match.index),
238 suffix: pattern.selector.substr(match.index + match[0].length)
239 };
240 }
241 },
242
243 apply: function()
244 {
245 this.getFiltersFunc(function(patterns)
246 {
247 this.propSelPatterns = [];
248 this.pseudoHasPatterns = [];
249 for (var i = 0; i < patterns.length; i++)
250 { 419 {
251 var pattern = patterns[i]; 420 let selectors = parseSelector(pattern.selector);
252 var parsed = this.parsePattern(pattern); 421 if (selectors != null && selectors.length > 0)
253 if (parsed == undefined) 422 this.patterns.push({selectors, text: pattern.text});
254 continue;
255 if (parsed.type == "props")
256 {
257 this.propSelPatterns.push(parsed);
258 }
259 else if (parsed.type == "has")
260 {
261 this.pseudoHasPatterns.push(parsed);
262 }
263 } 423 }
264 424
265 if (this.pseudoHasPatterns.length > 0 || this.propSelPatterns.length > 0) 425 if (this.patterns.length > 0)
266 { 426 {
267 var document = this.window.document; 427 let {document} = this.window;
268 this.addSelectors(document.styleSheets); 428 this.addSelectors(document.styleSheets);
269 this.hideElements();
270 document.addEventListener("load", this.onLoad.bind(this), true); 429 document.addEventListener("load", this.onLoad.bind(this), true);
271 } 430 }
272 }.bind(this)); 431 reportError = oldReportError;
432 });
273 } 433 }
274 }; 434 };
LEFTRIGHT

Powered by Google App Engine
This is Rietveld