Issue 3143 - Filter elements with :-abp-has()

chrome/content/elemHideEmulation.js

 /*
  * This file is part of Adblock Plus <https://adblockplus.org/>,
  * Copyright (C) 2006-2017 eyeo GmbH
  *
  * Adblock Plus is free software: you can redistribute it and/or modify
  * it under the terms of the GNU General Public License version 3 as
  * published by the Free Software Foundation.
  *
  * Adblock Plus is distributed in the hope that it will be useful,
  * but WITHOUT ANY WARRANTY; without even the implied warranty of
  * MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE.  See the
  * GNU General Public License for more details.
  *
  * You should have received a copy of the GNU General Public License
  * along with Adblock Plus.  If not, see <http://www.gnu.org/licenses/>.
  */
 
 /* globals filterToRegExp */
 
 "use strict";
 
 const abpSelectorRegexp = /:-abp-([\w-]+)\(/i;
 
+let reportError = () => {};
+
 function splitSelector(selector)
 {
   if (selector.indexOf(",") == -1)
     return [selector];
 
   let selectors = [];
   let start = 0;
   let level = 0;
   let sep = "";
 
@@ skipping 110 matching lines @@
     return [new PlainSelector(selector)];
 
   let selectors = [];
   if (match.index > 0)
     selectors.push(new PlainSelector(selector.substr(0, match.index)));
 
   let startIndex = match.index + match[0].length;
   let content = parseSelectorContent(selector, startIndex);
   if (!content)
   {
-    console.error(new SyntaxError("Failed parsing content filter " +
-                                  `selector ${selector}, didn't ` +
-                                  "find closing parenthesis."));
+    reportError(new SyntaxError("Failed to parse Adblock Plus " +
+                                `selector ${selector}, ` +
+                                "due to unmatched parentheses."));
     return null;
   }
   if (match[1] == "properties")
     selectors.push(new PropsSelector(content.text));
   else if (match[1] == "has")
   {
     let hasSelector = new HasSelector(content.text);
     if (!hasSelector.valid())
       return null;
     selectors.push(hasSelector);
   }
   else
   {
     // this is an error, can't parse selector.
-    console.error(new SyntaxError("Failed parsing content filter " +
-                                  `selector ${selector}, invalid ` +
-                                  `pseudo-class -abp-${match[1]}().`));
+    reportError(new SyntaxError("Failed to parse Adblock Plus " +
+                                `selector ${selector}, invalid ` +
+                                `pseudo-class :-abp-${match[1]}().`));
     return null;
   }
 
   let suffix = parseSelector(selector.substr(content.end + 1));
   if (suffix == null)
     return null;
 
   selectors.push(...suffix);
 
   return selectors;
@@ skipping 181 matching lines @@
 
       for (let rule of rules)
       {
         if (rule.type != rule.STYLE_RULE)
           continue;
 
         cssStyles.push(stringifyStyle(rule));
       }
     }
 
+    let {document} = this.window;
     for (let pattern of this.patterns)
     {
       for (let selector of evaluate(pattern.selectors,
                                     0, "", document, cssStyles))

[hub, 2017/06/12 15:10:08]

accessing document here will fail in Firefox. Will fix this.

       {
         if (!pattern.selectors.some(s => s.requiresHiding))
         {
           selectors.push(selector);
           selectorFilters.push(pattern.text);
         }
         else
         {
           for (let element of document.querySelectorAll(selector))
           {
@@ skipping 12 matching lines @@
   {
     let stylesheet = event.target.sheet;
     if (stylesheet)
       this.addSelectors([stylesheet]);
   },
 
   apply()
   {
     this.getFiltersFunc(patterns =>
     {
+      let oldReportError = reportError;
+      reportError = error => this.window.console.error(error);
+
       this.patterns = [];
       for (let pattern of patterns)
       {
         let selectors = parseSelector(pattern.selector);
         if (selectors != null && selectors.length > 0)
           this.patterns.push({selectors, text: pattern.text});
       }
 
       if (this.patterns.length > 0)
       {
         let {document} = this.window;
         this.addSelectors(document.styleSheets);
         document.addEventListener("load", this.onLoad.bind(this), true);
       }
+      reportError = oldReportError;
     });
   }
 };