Rietveld Code Review Tool
Help | Bug tracker | Discussion group | Source code | Sign in
(421)

Issue 29384022: Issue 4993 - Apply operator-linebreak ESLint rule consistently (Closed)

Can't Edit
Can't Publish+Mail
Start Review
Created:
2 years, 11 months ago by kzar
Modified:
2 years, 11 months ago
CC:
Thomas Greiner, Sebastian Noack
Visibility:
Public.

Description

Issue 4993 - Apply operator-linebreak ESLint rule consistently See the discussion here https://codereview.adblockplus.org/29374674/diff/29383722/lib/devtools.js#newcode89 . It turns out the default configuration for this rule is: "after", { "overrides": { "?": "before", ":": "before" } } Which makes a special exception for the `?` and `:` operators. Note: After means "linebreaks to be placed after the operator", which is kind of misleading.

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+1 line, -1 line) Patch
M eslint-config-eyeo/index.js View 1 chunk +1 line, -1 line 0 comments Download

Messages

Total messages: 8
kzar
Patch Set 1
2 years, 11 months ago (2017-03-15 04:13:11 UTC) #1
Wladimir Palant
LGTM
2 years, 11 months ago (2017-03-15 15:12:04 UTC) #2
Felix Dahlke
On 2017/03/15 15:12:04, Wladimir Palant wrote: > LGTM NOT LGTM - the Mozilla coding style ...
2 years, 11 months ago (2017-03-16 11:24:39 UTC) #3
kzar
On 2017/03/16 11:24:39, Felix Dahlke wrote: > On 2017/03/15 15:12:04, Wladimir Palant wrote: > > ...
2 years, 11 months ago (2017-03-16 12:01:04 UTC) #4
Felix Dahlke
On 2017/03/16 12:01:04, kzar wrote: > On 2017/03/16 11:24:39, Felix Dahlke wrote: > > On ...
2 years, 11 months ago (2017-03-16 12:12:23 UTC) #5
Wladimir Palant
On 2017/03/16 11:24:39, Felix Dahlke wrote: > "Overlong expressions not joined by && and || ...
2 years, 11 months ago (2017-03-16 14:25:12 UTC) #6
kzar
On 2017/03/16 14:25:12, Wladimir Palant wrote: > From what I know, we've been matching > ...
2 years, 11 months ago (2017-03-17 10:21:01 UTC) #7
Felix Dahlke
2 years, 11 months ago (2017-03-17 11:01:03 UTC) #8
LGTM then.
Sign in to reply to this message.

Powered by Google App Engine
RSS Feeds Recent Issues | This issue
This is Rietveld 87257f5