Issue 4991 - [emscripten] Update to Emscripten 1.37.3

Issue 4991 - [emscripten] Update to Emscripten 1.37.3

[Wladimir Palant, 2017-03-15 11:02:49]

https://codereview.adblockplus.org/29384673/diff/29384674/compile
File compile (right):

https://codereview.adblockplus.org/29384673/diff/29384674/compile#newcode31
compile:31: 'TEXTDECODER': 0,
TextDecoder is only used for functions that aren't being called anyway in our
case. Fallback code is being added regardless, so disabling TextDecoder reduces
code size a bit.

https://codereview.adblockplus.org/29384673/diff/29384674/compile#newcode32
compile:32: 'EXPORTED_RUNTIME_METHODS': ['cwrap', 'ccall', 'stringToAscii'],
This reduces code size a bit, almost no functions exported by default are being
used.

https://codereview.adblockplus.org/29384673/diff/29384674/compiled/bindings.ipp
File compiled/bindings.ipp (right):

https://codereview.adblockplus.org/29384673/diff/29384674/compiled/bindings.i...
compiled/bindings.ipp:506: var result = Runtime.stackAlloc(sizeofString);
We don't need to call this via Module, and above we don't. Then we don't need to
export this symbol either.

https://codereview.adblockplus.org/29384673/diff/29384674/compiled/bindings.i...
compiled/bindings.ipp:532: )");
Surprisingly, this is the only change that was really required for Emscripten
upgrade. For some reason, without this line break the closing curly bracket
isn't being printed.

[sergei, 2017-03-20 17:41:49]

https://codereview.adblockplus.org/29384673/diff/29384674/compiled/bindings.ipp
File compiled/bindings.ipp (right):

https://codereview.adblockplus.org/29384673/diff/29384674/compiled/bindings.i...
compiled/bindings.ipp:532: )");
On 2017/03/15 11:02:48, Wladimir Palant wrote:
> Surprisingly, this is the only change that was really required for Emscripten
> upgrade. For some reason, without this line break the closing curly bracket
> isn't being printed.

Should spaces at the beginning of `    )");` be removed?
It also concerns prefixing spaces (2 spaces) for all lines of the string
literal.

https://codereview.adblockplus.org/29384673/diff/29384674/compiled/bindings.i...
compiled/bindings.ipp:532: )");
On 2017/03/15 11:02:48, Wladimir Palant wrote:
> Surprisingly, this is the only change that was really required for Emscripten
> upgrade. For some reason, without this line break the closing curly bracket
> isn't being printed.

Actually the whole last line is removed. I think it's a bug in compiler.

[Wladimir Palant, 2017-03-21 10:18:59]

https://codereview.adblockplus.org/29384673/diff/29384674/compiled/bindings.ipp
File compiled/bindings.ipp (right):

https://codereview.adblockplus.org/29384673/diff/29384674/compiled/bindings.i...
compiled/bindings.ipp:532: )");
On 2017/03/20 17:41:49, sergei wrote:
> Should spaces at the beginning of `    )");` be removed?
> It also concerns prefixing spaces (2 spaces) for all lines of the string
> literal.
 
Luckily, we don't care about the resulting code being particularly beautiful,
the uglyfier will remove any extra whitespace anyway. But indentation is indeed
strange here, I've changed it to match the indentation of surrounding code.

[sergei, 2017-03-21 11:15:08]

LGTM