Rietveld Code Review Tool
Help | Bug tracker | Discussion group | Source code | Sign in
(33)

Issue 29384673: Issue 4991 - [emscripten] Update to Emscripten 1.37.3 (Closed)

Can't Edit
Can't Publish+Mail
Start Review
Created:
2 years, 6 months ago by Wladimir Palant
Modified:
2 years, 6 months ago
Reviewers:
sergei
CC:
Felix Dahlke
Base URL:
https://hg.adblockplus.org/adblockpluscore
Visibility:
Public.

Description

Issue 4991 - [emscripten] Update to Emscripten 1.37.3

Patch Set 1 #

Total comments: 7

Patch Set 2 : Fixed indentation #

Unified diffs Side-by-side diffs Delta from patch set Stats (+46 lines, -45 lines) Patch
M README.md View 1 chunk +1 line, -1 line 0 comments Download
M compile View 1 chunk +2 lines, -2 lines 0 comments Download
M compiled/bindings.ipp View 1 1 chunk +43 lines, -42 lines 0 comments Download

Messages

Total messages: 4
Wladimir Palant
https://codereview.adblockplus.org/29384673/diff/29384674/compile File compile (right): https://codereview.adblockplus.org/29384673/diff/29384674/compile#newcode31 compile:31: 'TEXTDECODER': 0, TextDecoder is only used for functions that ...
2 years, 6 months ago (2017-03-15 11:02:49 UTC) #1
sergei
https://codereview.adblockplus.org/29384673/diff/29384674/compiled/bindings.ipp File compiled/bindings.ipp (right): https://codereview.adblockplus.org/29384673/diff/29384674/compiled/bindings.ipp#newcode532 compiled/bindings.ipp:532: )"); On 2017/03/15 11:02:48, Wladimir Palant wrote: > Surprisingly, ...
2 years, 6 months ago (2017-03-20 17:41:49 UTC) #2
Wladimir Palant
https://codereview.adblockplus.org/29384673/diff/29384674/compiled/bindings.ipp File compiled/bindings.ipp (right): https://codereview.adblockplus.org/29384673/diff/29384674/compiled/bindings.ipp#newcode532 compiled/bindings.ipp:532: )"); On 2017/03/20 17:41:49, sergei wrote: > Should spaces ...
2 years, 6 months ago (2017-03-21 10:18:59 UTC) #3
sergei
2 years, 6 months ago (2017-03-21 11:15:08 UTC) #4
LGTM
Sign in to reply to this message.

Powered by Google App Engine
RSS Feeds Recent Issues | This issue
This is Rietveld 87257f5