Issue 4991 - [emscripten] Update to Emscripten 1.37.3

compiled/bindings.ipp

Index: compiled/bindings.ipp
===================================================================
--- a/compiled/bindings.ipp
+++ b/compiled/bindings.ipp
@@ -498,17 +498,17 @@ namespace bindings_internal
     var length = 0;
     var buffer = 0;
     if (str)
     {
       buffer = Runtime.stackAlloc(str.length * 2);
       length = copyString(str, buffer);
     }
 
-    var result = Module.Runtime.stackAlloc(sizeofString);
+    var result = Runtime.stackAlloc(sizeofString);

[Wladimir Palant, 2017/03/15 11:02:48]

We don't need to call this via Module, and above we don't. Then we don't need to
export this symbol either.

     Module._InitString(result, buffer, length);
     return result;
   }
 
   function readString(str)
   {
     var length = Module._GetStringLength(str);
     var pointer = Module._GetStringData(str) >> 1;
@@ -523,17 +523,18 @@ namespace bindings_internal
     };
     if (superclass)
       result.prototype = Object.create(superclass.prototype);
     result.prototype.delete = function()
     {
       Module._ReleaseRef(this._pointer + ref_counted_offset);
     };
     return result;
-  })");
+  }
+    )");

[Wladimir Palant, 2017/03/15 11:02:48]

Surprisingly, this is the only change that was really required for Emscripten
upgrade. For some reason, without this line break the closing curly bracket
isn't being printed.

[sergei, 2017/03/20 17:41:49]

Should spaces at the beginning of `    )");` be removed?
It also concerns prefixing spaces (2 spaces) for all lines of the string
literal.

[sergei, 2017/03/20 17:41:49]

Actually the whole last line is removed. I think it's a bug in compiler.

[Wladimir Palant, 2017/03/21 10:18:59]

Luckily, we don't care about the resulting code being particularly beautiful,
the uglyfier will remove any extra whitespace anyway. But indentation is indeed
strange here, I've changed it to match the indentation of surrounding code.

   }
 
   void printClass(const ClassInfo& cls)
   {
     DifferentiatorInfo differentiator = cls.subclass_differentiator;
     if (differentiator.offset != SIZE_MAX)
     {
       printf("var %s_mapping = \n", cls.name.c_str());