compiled/filter/Filter.h - Issue 29384812: Issue 4127 - [emscripten] Convert subscription classes to C++ - Part 1

Keyboard Shortcuts

	File
u :	up to issue
m :	publish + mail comments
M :	edit review message
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line
<Enter> :	respond to / edit current comment
d :	mark current comment as done

	Issue
u :	up to list of issues
m :	publish + mail comments
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue
# :	close issue

	Comment/message editing
<Ctrl> + s or <Ctrl> + Enter :	save comment
<Esc> :	cancel edit

Delta Between Two Patch Sets: compiled/filter/Filter.h

Issue 29384812: Issue 4127 - [emscripten] Convert subscription classes to C++ - Part 1 (Closed) Base URL: https://hg.adblockplus.org/adblockpluscore

Left Patch Set: Replace subscriptionClasses.js properly instead of creating a new file Created March 27, 2017, 9:06 a.m.

Right Patch Set: Addressed comments Created April 13, 2017, 1:02 p.m.

Left:
Right:

Use n/p to move between diff chunks; N/P to move between comments.

Jump to:

Left: Side by side diff | Download
Right: Side by side diff | Download

LEFT	RIGHT
1 /*	1 /*

2 * This file is part of Adblock Plus <https://adblockplus.org/>,	2 * This file is part of Adblock Plus <https://adblockplus.org/>,

3 * Copyright (C) 2006-2017 eyeo GmbH	3 * Copyright (C) 2006-2017 eyeo GmbH

4 *	4 *

5 * Adblock Plus is free software: you can redistribute it and/or modify	5 * Adblock Plus is free software: you can redistribute it and/or modify

6 * it under the terms of the GNU General Public License version 3 as	6 * it under the terms of the GNU General Public License version 3 as

7 * published by the Free Software Foundation.	7 * published by the Free Software Foundation.

8 *	8 *

9 * Adblock Plus is distributed in the hope that it will be useful,	9 * Adblock Plus is distributed in the hope that it will be useful,

10 * but WITHOUT ANY WARRANTY; without even the implied warranty of	10 * but WITHOUT ANY WARRANTY; without even the implied warranty of

(...skipping 21 matching lines...) Expand all Loading...
32 enum Type	32 enum Type

33 {	33 {

34 UNKNOWN = 0,	34 UNKNOWN = 0,

35 INVALID = 1,	35 INVALID = 1,

36 COMMENT = 2,	36 COMMENT = 2,

37 BLOCKING = 3,	37 BLOCKING = 3,

38 WHITELIST = 4,	38 WHITELIST = 4,

39 ELEMHIDE = 5,	39 ELEMHIDE = 5,

40 ELEMHIDEEXCEPTION = 6,	40 ELEMHIDEEXCEPTION = 6,

41 ELEMHIDEEMULATION = 7,	41 ELEMHIDEEMULATION = 7,

42 MAXTYPE = 7	42 VALUE_COUNT = 8

43 };	43 };

44	44

45 explicit Filter(Type type, const String& text);	45 explicit Filter(Type type, const String& text);

46 ~Filter();	46 ~Filter();

47	47

48 Type mType;	48 Type mType;

49	49

50 /* TODO	50 /* TODO

51 std::vector<Subscription> mSubscriptions;	51 std::vector<Subscription> mSubscriptions;

52 */	52 */

53	53

54 EMSCRIPTEN_KEEPALIVE const String& GetText() const	54 EMSCRIPTEN_KEEPALIVE const String& GetText() const

55 {	55 {

56 return mText;	56 return mText;

57 }	57 }

58	58

59 EMSCRIPTEN_KEEPALIVE OwnedString Serialize() const;	59 EMSCRIPTEN_KEEPALIVE OwnedString Serialize() const;

60	60

61 static EMSCRIPTEN_KEEPALIVE Filter* FromText(DependentString& text);	61 static EMSCRIPTEN_KEEPALIVE Filter* FromText(DependentString& text);

62 };	62 };

63	63

64 typedef intrusive_ptr<Filter> FilterPtr;	64 typedef intrusive_ptr<Filter> FilterPtr;

LEFT	RIGHT