Issue 4127 - [emscripten] Convert subscription classes to C++ - Part 1

compiled/filter/Filter.h

 /*
  * This file is part of Adblock Plus <https://adblockplus.org/>,
  * Copyright (C) 2006-2017 eyeo GmbH
  *
  * Adblock Plus is free software: you can redistribute it and/or modify
  * it under the terms of the GNU General Public License version 3 as
  * published by the Free Software Foundation.
  *
  * Adblock Plus is distributed in the hope that it will be useful,
  * but WITHOUT ANY WARRANTY; without even the implied warranty of
@@ skipping 21 matching lines @@
   enum Type
   {
     UNKNOWN = 0,
     INVALID = 1,
     COMMENT = 2,
     BLOCKING = 3,
     WHITELIST = 4,
     ELEMHIDE = 5,
     ELEMHIDEEXCEPTION = 6,
     ELEMHIDEEMULATION = 7,
-    MAXTYPE = 7

[sergei, 2017/04/12 12:04:33]

I think that the name reflecting the number of values would be better because
it's used as the number of different values.
Type::VALUES_NUMBER?

[Wladimir Palant, 2017/04/13 13:04:40]

Done.

+    VALUE_COUNT = 8
   };
 
   explicit Filter(Type type, const String& text);
   ~Filter();
 
   Type mType;
 
   /* TODO
   std::vector<Subscription> mSubscriptions;
   */
 
   EMSCRIPTEN_KEEPALIVE const String& GetText() const
   {
     return mText;
   }
 
   EMSCRIPTEN_KEEPALIVE OwnedString Serialize() const;
 
   static EMSCRIPTEN_KEEPALIVE Filter* FromText(DependentString& text);
 };
 
 typedef intrusive_ptr<Filter> FilterPtr;