Issue 4127 - [emscripten] Convert subscription classes to C++ - Part 1

compiled/subscription/UserDefinedSubscription.h

 /*
  * This file is part of Adblock Plus <https://adblockplus.org/>,
  * Copyright (C) 2006-2017 eyeo GmbH
  *
  * Adblock Plus is free software: you can redistribute it and/or modify
  * it under the terms of the GNU General Public License version 3 as
  * published by the Free Software Foundation.
  *
  * Adblock Plus is distributed in the hope that it will be useful,
  * but WITHOUT ANY WARRANTY; without even the implied warranty of
  * MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE.  See the
  * GNU General Public License for more details.
  *
  * You should have received a copy of the GNU General Public License
  * along with Adblock Plus.  If not, see <http://www.gnu.org/licenses/>.
  */
 
 #pragma once
 
 #include "Subscription.h"
 #include "../filter/Filter.h"
 
 class UserDefinedSubscription : public Subscription
 {
 private:
-  enum Defaults

[sergei, 2017/04/12 12:04:35]

It would be better to explain that it's about default filter types for the
instance of a subscription, maybe by renaming it to DefaultFilterTypes.

[Wladimir Palant, 2017/04/13 13:04:41]

Let's go with FilterCategory.

-  {
-    WHITELIST = 1,
-    BLOCKING = 2,
-    ELEMHIDE = 4,
-  };
-  static int filterTypeToDefaults[Filter::Type::MAXTYPE + 1];

[sergei, 2017/04/12 12:04:33]

Should it be Defaults instead of int?

[sergei, 2017/04/12 12:04:35]

Since it's private, what about moving it into cpp file in an anonymous namespace
and mark as const?

[Wladimir Palant, 2017/04/13 13:04:42]

Done.

[Wladimir Palant, 2017/04/13 13:04:42]

Done.

   int mDefaults;
 
 public:
   explicit UserDefinedSubscription(const String& id);
   EMSCRIPTEN_KEEPALIVE bool IsDefaultFor(const Filter* filter) const;
   EMSCRIPTEN_KEEPALIVE void MakeDefaultFor(const Filter* filter);
   EMSCRIPTEN_KEEPALIVE OwnedString Serialize() const;
 };