Rietveld Code Review Tool
Help | Bug tracker | Discussion group | Source code

Issue 29386580: Issue 5009 - Ignore frame redirections within popups (Closed)

Created:
March 17, 2017, 9:12 a.m. by kzar
Modified:
March 17, 2017, 12:30 p.m.
Reviewers:
Felix Dahlke
CC:
Sebastian Noack, Wladimir Palant
Visibility:
Public.

Description

Issue 5009 - Ignore frame redirections within popups

Patch Set 1 #

Patch Set 2 : Improve comment #

Unified diffs Side-by-side diffs Delta from patch set Stats (+4 lines, -0 lines) Patch
M lib/popupBlocker.js View 1 1 chunk +4 lines, -0 lines 0 comments Download

Messages

Total messages: 3
kzar
Patch Set 1
March 17, 2017, 9:15 a.m. (2017-03-17 09:15:49 UTC) #1
kzar
Patch Set 2 : Improve comment
March 17, 2017, 10:47 a.m. (2017-03-17 10:47:42 UTC) #2
Felix Dahlke
March 17, 2017, 10:50 a.m. (2017-03-17 10:50:39 UTC) #3
LGTM

Powered by Google App Engine
This is Rietveld