Issue 5010 - Allow to preload subscription files

libadblockplus-android/src/org/adblockplus/libadblockplus/android/AdblockEngine.java

 /*
  * This file is part of Adblock Plus <https://adblockplus.org/>,
  * Copyright (C) 2006-2016 Eyeo GmbH
  *
  * Adblock Plus is free software: you can redistribute it and/or modify
  * it under the terms of the GNU General Public License version 3 as
  * published by the Free Software Foundation.
  *
  * Adblock Plus is distributed in the hope that it will be useful,
  * but WITHOUT ANY WARRANTY; without even the implied warranty of
@@ skipping 215 matching lines @@
 
       engine.filterEngine = new FilterEngine(engine.jsEngine);
     }
   }
 
   public static Builder builder(AppInfo appInfo, String basePath)
   {
     return new Builder(appInfo, basePath);
   }
 
-  private AndroidWebRequestResourceWrapper.Listener resourceWrapperListener =
+  private final AndroidWebRequestResourceWrapper.Listener resourceWrapperListener =
     new AndroidWebRequestResourceWrapper.Listener()

[diegocarloslima, 2017/03/30 09:42:07]

Since this member variable never changes, you should consider declaring it final

[anton, 2017/03/30 10:27:16]

Acknowledged.

   {
     private static final int UPDATE_DELAY_MS = 1 * 1000;
 
-    private Handler handler = new Handler(Looper.getMainLooper());

[diegocarloslima, 2017/03/30 09:42:07]

Since this member variable never changes, you should consider declaring it final

[anton, 2017/03/30 10:27:16]

Acknowledged.

-
-    private Runnable forceUpdateRunnable = new Runnable()

[diegocarloslima, 2017/03/30 09:42:07]

Since this member variable never changes, you should consider declaring it final

+    private final Handler handler = new Handler(Looper.getMainLooper());
+
+    private final Runnable forceUpdateRunnable = new Runnable()
     {
       public void run() {
         // Filter Engine can be already disposed
         if (filterEngine != null)
         {
           Log.d(TAG, "Force update subscriptions");
-          filterEngine.forceUpdateCheck(updateCheckDoneCallback);
+          List<Subscription> subscriptions = filterEngine.getListedSubscriptions();
+          for (Subscription eachSubscription : subscriptions)

[sergei, 2017/03/30 22:14:37]

Nit: I would remove "each".

+          {
+            try
+            {
+              eachSubscription.updateFilters();
+            }
+            finally
+            {
+              eachSubscription.dispose();
+            }
+          }
         }
       }
     };
 
     @Override
     public void onIntercepted(String url, int resourceId)
     {
       // we need to force update subscriptions ASAP after preloaded one is returned
       // but we should note that multiple interceptions (for main easylist and AA) and force update once only
 
@@ skipping 317 matching lines @@
   public void setWhitelistedDomains(List<String> domains)
   {
     this.whitelistedDomains = domains;
   }
 
   public List<String> getWhitelistedDomains()
   {
     return whitelistedDomains;
   }
 }