Rietveld Code Review Tool
Help | Bug tracker | Discussion group | Source code

Side by Side Diff: include/AdblockPlus/FilterEngine.h

Issue 29389580: Issue 1397 - FilterEngine::ForceUpdateCheck crashes when passed a 0 std::function (Closed)
Patch Set: Created March 20, 2017, 2:11 p.m.
Left:
Right:
Use n/p to move between diff chunks; N/P to move between comments.
Jump to:
View unified diff | Download patch
« no previous file with comments | « no previous file | lib/api.js » ('j') | no next file with comments »
Toggle Intra-line Diffs ('i') | Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
OLDNEW
1 /* 1 /*
2 * This file is part of Adblock Plus <https://adblockplus.org/>, 2 * This file is part of Adblock Plus <https://adblockplus.org/>,
3 * Copyright (C) 2006-2016 Eyeo GmbH 3 * Copyright (C) 2006-2016 Eyeo GmbH
4 * 4 *
5 * Adblock Plus is free software: you can redistribute it and/or modify 5 * Adblock Plus is free software: you can redistribute it and/or modify
6 * it under the terms of the GNU General Public License version 3 as 6 * it under the terms of the GNU General Public License version 3 as
7 * published by the Free Software Foundation. 7 * published by the Free Software Foundation.
8 * 8 *
9 * Adblock Plus is distributed in the hope that it will be useful, 9 * Adblock Plus is distributed in the hope that it will be useful,
10 * but WITHOUT ANY WARRANTY; without even the implied warranty of 10 * but WITHOUT ANY WARRANTY; without even the implied warranty of
(...skipping 450 matching lines...) Expand 10 before | Expand all | Expand 10 after
461 * `FilterEngine` will automatically check for updates in regular intervals, 461 * `FilterEngine` will automatically check for updates in regular intervals,
462 * so applications should only call this when the user triggers an update 462 * so applications should only call this when the user triggers an update
463 * check manually. 463 * check manually.
464 * @param callback Optional callback to invoke when the update check is 464 * @param callback Optional callback to invoke when the update check is
465 * finished. The string parameter will be empty when the update check 465 * finished. The string parameter will be empty when the update check
466 * succeeded, or contain an error message if it failed. 466 * succeeded, or contain an error message if it failed.
467 * Note that the callback will be invoked whether updates are 467 * Note that the callback will be invoked whether updates are
468 * available or not - to react to updates being available, use 468 * available or not - to react to updates being available, use
469 * `FilterEngine::SetUpdateAvailableCallback()`. 469 * `FilterEngine::SetUpdateAvailableCallback()`.
470 */ 470 */
471 void ForceUpdateCheck(UpdateCheckDoneCallback callback); 471 void ForceUpdateCheck(const UpdateCheckDoneCallback& callback = UpdateCheckD oneCallback());
472 472
473 /** 473 /**
474 * Sets the callback invoked when the filters change. 474 * Sets the callback invoked when the filters change.
475 * @param callback Callback to invoke. 475 * @param callback Callback to invoke.
476 */ 476 */
477 void SetFilterChangeCallback(FilterChangeCallback callback); 477 void SetFilterChangeCallback(FilterChangeCallback callback);
478 478
479 /** 479 /**
480 * Removes the callback invoked when the filters change. 480 * Removes the callback invoked when the filters change.
481 */ 481 */
(...skipping 60 matching lines...) Expand 10 before | Expand all | Expand 10 after
542 const JsValueList& params); 542 const JsValueList& params);
543 FilterPtr GetWhitelistingFilter(const std::string& url, 543 FilterPtr GetWhitelistingFilter(const std::string& url,
544 ContentTypeMask contentTypeMask, const std::string& documentUrl) const; 544 ContentTypeMask contentTypeMask, const std::string& documentUrl) const;
545 FilterPtr GetWhitelistingFilter(const std::string& url, 545 FilterPtr GetWhitelistingFilter(const std::string& url,
546 ContentTypeMask contentTypeMask, 546 ContentTypeMask contentTypeMask,
547 const std::vector<std::string>& documentUrls) const; 547 const std::vector<std::string>& documentUrls) const;
548 }; 548 };
549 } 549 }
550 550
551 #endif 551 #endif
OLDNEW
« no previous file with comments | « no previous file | lib/api.js » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld