Rietveld Code Review Tool
Help | Bug tracker | Discussion group | Source code | Sign in
(34)

Issue 29390657: Issue 5020 - Part 2: Fix usage of paths in compile script (Closed)

Can't Edit
Can't Publish+Mail
Start Review
Created:
2 years, 8 months ago by Wladimir Palant
Modified:
2 years, 7 months ago
Reviewers:
Vasily Kuznetsov
CC:
hub
Base URL:
https://hg.adblockplus.org/adblockpluscore
Visibility:
Public.

Description

Issue 5020 - Part 2: Fix usage of paths in compile script

Patch Set 1 #

Total comments: 6

Patch Set 2 : Removed fallback #

Unified diffs Side-by-side diffs Delta from patch set Stats (+4 lines, -3 lines) Patch
M compile View 1 1 chunk +4 lines, -3 lines 0 comments Download

Messages

Total messages: 8
Wladimir Palant
2 years, 8 months ago (2017-03-21 11:22:14 UTC) #1
Vasily Kuznetsov
https://codereview.adblockplus.org/29390657/diff/29390658/compile File compile (right): https://codereview.adblockplus.org/29390657/diff/29390658/compile#newcode7 compile:7: BASE_DIR = os.path.dirname(__file__) or os.getcwd() BASE_DIR (which I suppose ...
2 years, 8 months ago (2017-03-21 18:01:42 UTC) #2
Wladimir Palant
https://codereview.adblockplus.org/29390657/diff/29390658/compile File compile (right): https://codereview.adblockplus.org/29390657/diff/29390658/compile#newcode7 compile:7: BASE_DIR = os.path.dirname(__file__) or os.getcwd() On 2017/03/21 18:01:42, Vasily ...
2 years, 7 months ago (2017-03-22 08:44:20 UTC) #3
Vasily Kuznetsov
Sorry for the persistence, I just want to make sure I understand the context and ...
2 years, 7 months ago (2017-03-22 09:52:58 UTC) #4
Wladimir Palant
https://codereview.adblockplus.org/29390657/diff/29390658/compile File compile (right): https://codereview.adblockplus.org/29390657/diff/29390658/compile#newcode7 compile:7: BASE_DIR = os.path.dirname(__file__) or os.getcwd() On 2017/03/22 09:52:58, Vasily ...
2 years, 7 months ago (2017-03-22 14:59:29 UTC) #5
Vasily Kuznetsov
https://codereview.adblockplus.org/29390657/diff/29390658/compile File compile (right): https://codereview.adblockplus.org/29390657/diff/29390658/compile#newcode7 compile:7: BASE_DIR = os.path.dirname(__file__) or os.getcwd() On 2017/03/22 14:59:29, Wladimir ...
2 years, 7 months ago (2017-03-22 19:16:01 UTC) #6
Wladimir Palant
https://codereview.adblockplus.org/29390657/diff/29390658/compile File compile (right): https://codereview.adblockplus.org/29390657/diff/29390658/compile#newcode7 compile:7: BASE_DIR = os.path.dirname(__file__) or os.getcwd() On 2017/03/22 19:16:01, Vasily ...
2 years, 7 months ago (2017-03-23 11:55:28 UTC) #7
Vasily Kuznetsov
2 years, 7 months ago (2017-03-23 12:10:36 UTC) #8
LGTM
Sign in to reply to this message.

Powered by Google App Engine
RSS Feeds Recent Issues | This issue
This is Rietveld 87257f5