Issue 5020 - Part 3: Add command line options to compile script

Issue 5020 - Part 3: Add command line options to compile script

[Vasily Kuznetsov, 2017-03-21 18:38:19]

LGTM

I have one small concern (see below) but I think it's not serious enough so it's
up to you if you want to implement my suggestion or resolve it some other way.

https://codereview.adblockplus.org/29390663/diff/29390664/compile
File compile (right):

https://codereview.adblockplus.org/29390663/diff/29390664/compile#newcode106
compile:106: ADDITIONAL_PARAMS.append('-g1')
Isn't it a bit misleading that ADDITIONAL_PARAMETERS is named like a constant
but we're modifying it? Maybe it would be better to make a new list and put it
into `env`?
To be honest I have a hard time coming up with realistic scenarios of how
current approach would bite us in the future. However, sometimes reality exceeds
our expectations :)

[Wladimir Palant, 2017-03-22 08:52:12]

https://codereview.adblockplus.org/29390663/diff/29390664/compile
File compile (right):

https://codereview.adblockplus.org/29390663/diff/29390664/compile#newcode106
compile:106: ADDITIONAL_PARAMS.append('-g1')
On 2017/03/21 18:38:19, Vasily Kuznetsov wrote:
> Isn't it a bit misleading that ADDITIONAL_PARAMETERS is named like a constant
> but we're modifying it?

I have been wondering the same thing. Yes, let's do it properly.

[Vasily Kuznetsov, 2017-03-22 09:58:10]

On 2017/03/22 08:52:12, Wladimir Palant wrote:
> https://codereview.adblockplus.org/29390663/diff/29390664/compile
> File compile (right):
> 
> https://codereview.adblockplus.org/29390663/diff/29390664/compile#newcode106
> compile:106: ADDITIONAL_PARAMS.append('-g1')
> On 2017/03/21 18:38:19, Vasily Kuznetsov wrote:
> > Isn't it a bit misleading that ADDITIONAL_PARAMETERS is named like a
constant
> > but we're modifying it?
> 
> I have been wondering the same thing. Yes, let's do it properly.

Yeah, this is nicer. LGTM