Rietveld Code Review Tool
Help | Bug tracker | Discussion group | Source code

Issue 29391717: Issue 5023 - Update adblockplusui dependency to 8ceaabb9c639 (Closed)

Created:
March 22, 2017, 8:16 a.m. by Jon Sonesen
Modified:
March 22, 2017, 9:22 a.m.
Reviewers:
Sebastian Noack
Visibility:
Public.

Description

updates adblockplusui dependency

Patch Set 1 #

Total comments: 1

Patch Set 2 : #

Total comments: 2

Patch Set 3 : #

Unified diffs Side-by-side diffs Delta from patch set Stats (+2 lines, -2 lines) Patch
M dependencies View 1 2 1 chunk +1 line, -1 line 0 comments Download
M options.js View 1 chunk +1 line, -1 line 0 comments Download

Messages

Total messages: 6
Jon Sonesen
March 22, 2017, 8:16 a.m. (2017-03-22 08:16:52 UTC) #1
Sebastian Noack
https://codereview.adblockplus.org/29391717/diff/29391718/dependencies File dependencies (right): https://codereview.adblockplus.org/29391717/diff/29391718/dependencies#newcode6 dependencies:6: adblockplusui = adblockplusui hg:2e2db8b4ee74 git:3c766eb Please include the latest ...
March 22, 2017, 8:41 a.m. (2017-03-22 08:41:46 UTC) #2
Jon Sonesen
On 2017/03/22 08:41:46, Sebastian Noack wrote: > https://codereview.adblockplus.org/29391717/diff/29391718/dependencies > File dependencies (right): > > https://codereview.adblockplus.org/29391717/diff/29391718/dependencies#newcode6 ...
March 22, 2017, 8:51 a.m. (2017-03-22 08:51:35 UTC) #3
Sebastian Noack
https://codereview.adblockplus.org/29391717/diff/29391723/dependencies File dependencies (right): https://codereview.adblockplus.org/29391717/diff/29391723/dependencies#newcode6 dependencies:6: adblockplusui = adblockplusui hg:8ceaabb9c639 git:6222fd2 Nit: You added a ...
March 22, 2017, 8:52 a.m. (2017-03-22 08:52:31 UTC) #4
Jon Sonesen
https://codereview.adblockplus.org/29391717/diff/29391723/dependencies File dependencies (right): https://codereview.adblockplus.org/29391717/diff/29391723/dependencies#newcode6 dependencies:6: adblockplusui = adblockplusui hg:8ceaabb9c639 git:6222fd2 On 2017/03/22 08:52:31, Sebastian ...
March 22, 2017, 8:54 a.m. (2017-03-22 08:54:05 UTC) #5
Sebastian Noack
March 22, 2017, 9:05 a.m. (2017-03-22 09:05:17 UTC) #6
LGTM

Powered by Google App Engine
This is Rietveld