Rietveld Code Review Tool
Help | Bug tracker | Discussion group | Source code

Side by Side Diff: test/Notification.cpp

Issue 29391770: Noissue - Fix sign comparison warnings in tests. (Closed) Base URL: https://hg.adblockplus.org/libadblockplus/
Patch Set: Created March 22, 2017, 3:32 p.m.
Left:
Right:
Use n/p to move between diff chunks; N/P to move between comments.
Jump to:
View unified diff | Download patch
« no previous file with comments | « no previous file | test/ReferrerMapping.cpp » ('j') | no next file with comments »
Toggle Intra-line Diffs ('i') | Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
OLDNEW
1 /* 1 /*
2 * This file is part of Adblock Plus <https://adblockplus.org/>, 2 * This file is part of Adblock Plus <https://adblockplus.org/>,
3 * Copyright (C) 2006-2016 Eyeo GmbH 3 * Copyright (C) 2006-2016 Eyeo GmbH
4 * 4 *
5 * Adblock Plus is free software: you can redistribute it and/or modify 5 * Adblock Plus is free software: you can redistribute it and/or modify
6 * it under the terms of the GNU General Public License version 3 as 6 * it under the terms of the GNU General Public License version 3 as
7 * published by the Free Software Foundation. 7 * published by the Free Software Foundation.
8 * 8 *
9 * Adblock Plus is distributed in the hope that it will be useful, 9 * Adblock Plus is distributed in the hope that it will be useful,
10 * but WITHOUT ANY WARRANTY; without even the implied warranty of 10 * but WITHOUT ANY WARRANTY; without even the implied warranty of
(...skipping 180 matching lines...) Expand 10 before | Expand all | Expand 10 after
191 ASSERT_TRUE(notification); 191 ASSERT_TRUE(notification);
192 notification->MarkAsShown(); 192 notification->MarkAsShown();
193 EXPECT_FALSE(PeekNotification()); 193 EXPECT_FALSE(PeekNotification());
194 } 194 }
195 195
196 TEST_F(NotificationTest, NoLinks) 196 TEST_F(NotificationTest, NoLinks)
197 { 197 {
198 AddNotification("{ id: 'id'}"); 198 AddNotification("{ id: 'id'}");
199 NotificationPtr notification = PeekNotification(); 199 NotificationPtr notification = PeekNotification();
200 ASSERT_TRUE(notification); 200 ASSERT_TRUE(notification);
201 EXPECT_EQ(0, notification->GetLinks().size()); 201 EXPECT_EQ(0u, notification->GetLinks().size());
202 } 202 }
203 203
204 TEST_F(NotificationTest, Links) 204 TEST_F(NotificationTest, Links)
205 { 205 {
206 AddNotification("{ id: 'id', links: ['link1', 'link2'] }"); 206 AddNotification("{ id: 'id', links: ['link1', 'link2'] }");
207 NotificationPtr notification = PeekNotification(); 207 NotificationPtr notification = PeekNotification();
208 ASSERT_TRUE(notification); 208 ASSERT_TRUE(notification);
209 std::vector<std::string> notificationLinks = notification->GetLinks(); 209 std::vector<std::string> notificationLinks = notification->GetLinks();
210 ASSERT_EQ(2, notificationLinks.size()); 210 ASSERT_EQ(2u, notificationLinks.size());
211 EXPECT_EQ("link1", notificationLinks[0]); 211 EXPECT_EQ("link1", notificationLinks[0]);
212 EXPECT_EQ("link2", notificationLinks[1]); 212 EXPECT_EQ("link2", notificationLinks[1]);
213 } 213 }
OLDNEW
« no previous file with comments | « no previous file | test/ReferrerMapping.cpp » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld