Issue 5013 - Improve some const-correctness

src/Notification.cpp

 /*
  * This file is part of Adblock Plus <https://adblockplus.org/>,
  * Copyright (C) 2006-2017 eyeo GmbH
  *
  * Adblock Plus is free software: you can redistribute it and/or modify
  * it under the terms of the GNU General Public License version 3 as
  * published by the Free Software Foundation.
  *
  * Adblock Plus is distributed in the hope that it will be useful,
  * but WITHOUT ANY WARRANTY; without even the implied warranty of
@@ skipping 75 matching lines @@
 
 std::vector<std::string> Notification::GetLinks() const
 {
   std::vector<std::string> retValue;
   JsValuePtr jsLinks = GetProperty("links");
   if (!jsLinks->IsArray())
   {
     return retValue;
   }
   JsValueList urlLinksList = jsLinks->AsList();
-  for (JsValueList::const_iterator linkIterator = urlLinksList.begin();
-    linkIterator != urlLinksList.end(); ++linkIterator)
+  for (const auto& link : urlLinksList)
   {
-    retValue.push_back((*linkIterator)->AsString());
+    retValue.push_back(link->AsString());
   }
   return retValue;
 }
 
 void Notification::MarkAsShown()
 {
   jsEngine->Evaluate("API.markNotificationAsShown")->Call(*GetProperty("id"));
-}
+}