Rietveld Code Review Tool
Help | Bug tracker | Discussion group | Source code

Delta Between Two Patch Sets: src/Notification.cpp

Issue 29391775: Issue 5013 - Improve some const-correctness (Closed) Base URL: https://hg.adblockplus.org/libadblockplus/
Left Patch Set: Created March 22, 2017, 3:37 p.m.
Right Patch Set: Removed GetType() const-ness change Created March 23, 2017, 12:57 p.m.
Left:
Right:
Use n/p to move between diff chunks; N/P to move between comments.
Jump to:
Left: Side by side diff | Download
Right: Side by side diff | Download
« no previous file with change/comment | « src/JsValue.cpp ('k') | src/WebRequestJsObject.cpp » ('j') | no next file with change/comment »
Toggle Intra-line Diffs ('i') | Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
LEFTRIGHT
1 /* 1 /*
2 * This file is part of Adblock Plus <https://adblockplus.org/>, 2 * This file is part of Adblock Plus <https://adblockplus.org/>,
3 * Copyright (C) 2006-2016 Eyeo GmbH 3 * Copyright (C) 2006-2017 eyeo GmbH
4 * 4 *
5 * Adblock Plus is free software: you can redistribute it and/or modify 5 * Adblock Plus is free software: you can redistribute it and/or modify
6 * it under the terms of the GNU General Public License version 3 as 6 * it under the terms of the GNU General Public License version 3 as
7 * published by the Free Software Foundation. 7 * published by the Free Software Foundation.
8 * 8 *
9 * Adblock Plus is distributed in the hope that it will be useful, 9 * Adblock Plus is distributed in the hope that it will be useful,
10 * but WITHOUT ANY WARRANTY; without even the implied warranty of 10 * but WITHOUT ANY WARRANTY; without even the implied warranty of
11 * MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE. See the 11 * MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE. See the
12 * GNU General Public License for more details. 12 * GNU General Public License for more details.
13 * 13 *
(...skipping 72 matching lines...) Expand 10 before | Expand all | Expand 10 after
86 86
87 std::vector<std::string> Notification::GetLinks() const 87 std::vector<std::string> Notification::GetLinks() const
88 { 88 {
89 std::vector<std::string> retValue; 89 std::vector<std::string> retValue;
90 JsValuePtr jsLinks = GetProperty("links"); 90 JsValuePtr jsLinks = GetProperty("links");
91 if (!jsLinks->IsArray()) 91 if (!jsLinks->IsArray())
92 { 92 {
93 return retValue; 93 return retValue;
94 } 94 }
95 JsValueList urlLinksList = jsLinks->AsList(); 95 JsValueList urlLinksList = jsLinks->AsList();
96 for (auto linkIterator = urlLinksList.cbegin(); 96 for (const auto& link : urlLinksList)
97 linkIterator != urlLinksList.cend(); ++linkIterator)
98 { 97 {
99 retValue.push_back((*linkIterator)->AsString()); 98 retValue.push_back(link->AsString());
100 } 99 }
101 return retValue; 100 return retValue;
102 } 101 }
103 102
104 void Notification::MarkAsShown() 103 void Notification::MarkAsShown()
105 { 104 {
106 jsEngine->Evaluate("API.markNotificationAsShown")->Call(*GetProperty("id")); 105 jsEngine->Evaluate("API.markNotificationAsShown")->Call(*GetProperty("id"));
107 } 106 }
LEFTRIGHT

Powered by Google App Engine
This is Rietveld