Issue 5013 - Improve some const-correctness

src/WebRequestJsObject.cpp

 /*
  * This file is part of Adblock Plus <https://adblockplus.org/>,
- * Copyright (C) 2006-2016 Eyeo GmbH
+ * Copyright (C) 2006-2017 eyeo GmbH
  *
  * Adblock Plus is free software: you can redistribute it and/or modify
  * it under the terms of the GNU General Public License version 3 as
  * published by the Free Software Foundation.
  *
  * Adblock Plus is distributed in the hope that it will be useful,
  * but WITHOUT ANY WARRANTY; without even the implied warranty of
  * MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE.  See the
  * GNU General Public License for more details.
  *
@@ skipping 20 matching lines @@
     {
       if (!url.length())
         throw std::runtime_error("Invalid string passed as first argument to GET");
 
       {
         AdblockPlus::JsValuePtr headersObj = arguments[1];
         if (!headersObj->IsObject())
           throw std::runtime_error("Second argument to GET must be an object");
 
         std::vector<std::string> properties = headersObj->GetOwnPropertyNames();
-        for (auto it = properties.cbegin(); it != properties.cend(); ++it)
+        for (const auto& header : properties)
         {
-          const std::string & header = *it;

[sergei, 2017/03/22 15:44:00]

please no space before & here

[hub, 2017/03/22 18:16:59]

This is gone as I now use the range iterator.
And I made sure to lose the space.

(patch already updated)

           std::string headerValue = headersObj->GetProperty(header)->AsString();
           if (header.length() && headerValue.length())
             headers.push_back(std::pair<std::string, std::string>(header, headerValue));
         }
       }
 
       callback = arguments[2];
       if (!callback->IsFunction())
         throw std::runtime_error("Third argument to GET must be a function");
     }
@@ skipping 12 matching lines @@
         jsEngine->GetWebRequest()->GET(url, headers) : NotAllowedResponse();
 
       AdblockPlus::JsContext context(jsEngine);
 
       AdblockPlus::JsValuePtr resultObject = jsEngine->NewObject();
       resultObject->SetProperty("status", result.status);
       resultObject->SetProperty("responseStatus", result.responseStatus);
       resultObject->SetProperty("responseText", result.responseText);
 
       AdblockPlus::JsValuePtr headersObject = jsEngine->NewObject();
-      for (auto it = result.responseHeaders.cbegin();
-        it != result.responseHeaders.cend(); ++it)
+      for (const auto& header : result.responseHeaders)
       {
-        headersObject->SetProperty(it->first, it->second);
+        headersObject->SetProperty(header.first, header.second);
       }
       resultObject->SetProperty("responseHeaders", headersObject);
 
       AdblockPlus::JsValueList params;
       params.push_back(resultObject);
       callback->Call(params);
     }
 
   private:
     AdblockPlus::JsEnginePtr jsEngine;
@@ skipping 23 matching lines @@
     return v8::Undefined();
   }
 }
 
 AdblockPlus::JsValuePtr AdblockPlus::WebRequestJsObject::Setup(
     AdblockPlus::JsEnginePtr jsEngine, AdblockPlus::JsValuePtr obj)
 {
   obj->SetProperty("GET", jsEngine->NewCallback(::GETCallback));
   return obj;
 }