Rietveld Code Review Tool
Help | Bug tracker | Discussion group | Source code

Issue 29393564: Noissue - [emscripten] Always process source files in the same order to get reliable builds (Closed)

Created:
March 23, 2017, 2:54 p.m. by Wladimir Palant
Modified:
March 27, 2017, 8 a.m.
Reviewers:
sergei
Base URL:
https://hg.adblockplus.org/adblockpluscore
Visibility:
Public.

Description

Noissue - [emscripten] Always process source files in the same order to get reliable builds

Patch Set 1 #

Total comments: 2
Unified diffs Side-by-side diffs Delta from patch set Stats (+3 lines, -1 line) Patch
M compile View 1 chunk +3 lines, -1 line 2 comments Download

Messages

Total messages: 5
Wladimir Palant
March 23, 2017, 2:54 p.m. (2017-03-23 14:54:09 UTC) #1
Wladimir Palant
Note that this is only partially successful - the builds produced on Linux and Windows ...
March 23, 2017, 2:57 p.m. (2017-03-23 14:57:39 UTC) #2
sergei
https://codereview.adblockplus.org/29393564/diff/29393565/compile File compile (right): https://codereview.adblockplus.org/29393564/diff/29393565/compile#newcode71 compile:71: # Order matters. We sort source files so that ...
March 23, 2017, 3:06 p.m. (2017-03-23 15:06:16 UTC) #3
Wladimir Palant
https://codereview.adblockplus.org/29393564/diff/29393565/compile File compile (right): https://codereview.adblockplus.org/29393564/diff/29393565/compile#newcode71 compile:71: # Order matters. We sort source files so that ...
March 24, 2017, 6:02 a.m. (2017-03-24 06:02:13 UTC) #4
sergei
March 24, 2017, 11:32 a.m. (2017-03-24 11:32:02 UTC) #5
On 2017/03/24 06:02:13, Wladimir Palant wrote:
> https://codereview.adblockplus.org/29393564/diff/29393565/compile
> File compile (right):
> 
> https://codereview.adblockplus.org/29393564/diff/29393565/compile#newcode71
> compile:71: # Order matters. We sort source files so that we always get the
same
> On 2017/03/23 15:06:15, sergei wrote:
> > It looks strange, what is the difference between different order of cpp
files
> > and why is the alphabetical order correct?
> 
> There is no "correct" order but each order will produce a slightly different
> result - presumably, this difference to cased by the optimizer. The point is
> having reproducible builds (e.g. Mozilla would want to verify that the file
> matches the source code in their reviews).

LGTM

Powered by Google App Engine
This is Rietveld