Issue 4692 - Dont' keep a strong reference from timer thread

src/GlobalJsObject.cpp

 /*
  * This file is part of Adblock Plus <https://adblockplus.org/>,
  * Copyright (C) 2006-2016 Eyeo GmbH
  *
  * Adblock Plus is free software: you can redistribute it and/or modify
  * it under the terms of the GNU General Public License version 3 as
  * published by the Free Software Foundation.
  *
  * Adblock Plus is distributed in the hope that it will be useful,
  * but WITHOUT ANY WARRANTY; without even the implied warranty of
@@ skipping 19 matching lines @@
 #include "Utils.h"
 
 using namespace AdblockPlus;
 
 namespace
 {
   class TimeoutThread : public Thread
   {
   public:
     TimeoutThread(const JsEngine::TimerTask& timerTask)
-      : Thread(true)
-      , timerTask(timerTask)

[Oleksandr, 2017/03/24 12:15:25]

Nit: I think our coding style would put a comma on the previous line

[sergei, 2017/03/24 12:34:39]

Done.

+      : Thread(true), timerTask(timerTask)
     {
     }
 
     void Run()
     {
-      Sleep(timerTask.ii_taskInfo->delay);
+      Sleep(timerTask.taskInfoIterator->delay);
       if (auto jsEngine = timerTask.weakJsEngine.lock())
-        jsEngine->CallTimerTask(timerTask.ii_taskInfo);
+        jsEngine->CallTimerTask(timerTask.taskInfoIterator);
     }
 
   private:
     JsEngine::TimerTask timerTask;
   };
 
   v8::Handle<v8::Value> SetTimeoutCallback(const v8::Arguments& arguments)
   {
     TimeoutThread* timeoutThread;
     try
@@ skipping 39 matching lines @@
   obj->SetProperty("_fileSystem",
       FileSystemJsObject::Setup(jsEngine, jsEngine->NewObject()));
   obj->SetProperty("_webRequest",
       WebRequestJsObject::Setup(jsEngine, jsEngine->NewObject()));
   obj->SetProperty("console",
       ConsoleJsObject::Setup(jsEngine, jsEngine->NewObject()));
   obj->SetProperty("_appInfo",
       AppInfoJsObject::Setup(jsEngine, appInfo, jsEngine->NewObject()));
   return obj;
 }