Issue 5013 - Make more methods const.- introduced JsConstValuePtr and JsConstValueList- JsValue:…

src/FileSystemJsObject.cpp

 /*
  * This file is part of Adblock Plus <https://adblockplus.org/>,
  * Copyright (C) 2006-2017 eyeo GmbH
  *
  * Adblock Plus is free software: you can redistribute it and/or modify
  * it under the terms of the GNU General Public License version 3 as
  * published by the Free Software Foundation.
  *
  * Adblock Plus is distributed in the hope that it will be useful,
  * but WITHOUT ANY WARRANTY; without even the implied warranty of
@@ skipping 58 matching lines @@
       }
       catch (...)
       {
         error =  "Unknown error while reading from " + path;
       }
 
       const JsContext context(jsEngine);
       JsValuePtr result = jsEngine->NewObject();
       result->SetProperty("content", content);
       result->SetProperty("error", error);
-      JsValueList params;
+      JsConstValueList params;
       params.push_back(result);
       callback->Call(params);
     }
 
   private:
     std::string path;
   };
 
   class WriteThread : public IoThread
   {
@@ skipping 17 matching lines @@
       {
         error = e.what();
       }
       catch (...)
       {
         error = "Unknown error while writing to " + path;
       }
 
       const JsContext context(jsEngine);
       JsValuePtr errorValue = jsEngine->NewValue(error);
-      JsValueList params;
+      JsConstValueList params;
       params.push_back(errorValue);
       callback->Call(params);
     }
 
   private:
     std::string path;
     std::string content;
   };
 
   class MoveThread : public IoThread
@@ skipping 16 matching lines @@
       {
         error = e.what();
       }
       catch (...)
       {
         error = "Unknown error while moving " + fromPath + " to " + toPath;
       }
 
       const JsContext context(jsEngine);
       JsValuePtr errorValue = jsEngine->NewValue(error);
-      JsValueList params;
+      JsConstValueList params;
       params.push_back(errorValue);
       callback->Call(params);
     }
 
   private:
     std::string fromPath;
     std::string toPath;
   };
 
   class RemoveThread : public IoThread
@@ skipping 16 matching lines @@
       {
         error = e.what();
       }
       catch (...)
       {
         error = "Unknown error while removing " + path;
       }
 
       const JsContext context(jsEngine);
       JsValuePtr errorValue = jsEngine->NewValue(error);
-      JsValueList params;
+      JsConstValueList params;
       params.push_back(errorValue);
       callback->Call(params);
     }
 
   private:
     std::string path;
   };
 
 
   class StatThread : public IoThread
@@ skipping 23 matching lines @@
       }
 
       const JsContext context(jsEngine);
       JsValuePtr result = jsEngine->NewObject();
       result->SetProperty("exists", statResult.exists);
       result->SetProperty("isFile", statResult.isFile);
       result->SetProperty("isDirectory", statResult.isDirectory);
       result->SetProperty("lastModified", statResult.lastModified);
       result->SetProperty("error", error);
 
-      JsValueList params;
+      JsConstValueList params;
       params.push_back(result);
       callback->Call(params);
     }
 
   private:
     std::string path;
   };
 
   v8::Handle<v8::Value> ReadCallback(const v8::Arguments& arguments)
   {
@@ skipping 106 matching lines @@
 JsValuePtr FileSystemJsObject::Setup(JsEnginePtr jsEngine, JsValuePtr obj)
 {
   obj->SetProperty("read", jsEngine->NewCallback(::ReadCallback));
   obj->SetProperty("write", jsEngine->NewCallback(::WriteCallback));
   obj->SetProperty("move", jsEngine->NewCallback(::MoveCallback));
   obj->SetProperty("remove", jsEngine->NewCallback(::RemoveCallback));
   obj->SetProperty("stat", jsEngine->NewCallback(::StatCallback));
   obj->SetProperty("resolve", jsEngine->NewCallback(::ResolveCallback));
   return obj;
 }