Rietveld Code Review Tool
Help | Bug tracker | Discussion group | Source code

Unified Diff: include/AdblockPlus/JsValue.h

Issue 29393589: Issue 5013 - Make more methods const.- introduced JsConstValuePtr and JsConstValueList- JsValue:… (Closed) Base URL: https://hg.adblockplus.org/libadblockplus/
Patch Set: Now mostly use the single param Call() overload Created March 24, 2017, 2:10 p.m.
Use n/p to move between diff chunks; N/P to move between comments.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « include/AdblockPlus/FilterEngine.h ('k') | src/FileSystemJsObject.cpp » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: include/AdblockPlus/JsValue.h
===================================================================
--- a/include/AdblockPlus/JsValue.h
+++ b/include/AdblockPlus/JsValue.h
@@ -37,21 +37,23 @@ namespace AdblockPlus
class JsEngine;
typedef std::shared_ptr<JsEngine> JsEnginePtr;
/**
* Shared smart pointer to a `JsValue` instance.
*/
typedef std::shared_ptr<JsValue> JsValuePtr;
+ typedef std::shared_ptr<const JsValue> JsConstValuePtr;
/**
* List of JavaScript values.
*/
typedef std::vector<AdblockPlus::JsValuePtr> JsValueList;
+ typedef std::vector<AdblockPlus::JsConstValuePtr> JsConstValueList;
/**
* Wrapper for JavaScript values.
* See `JsEngine` for creating `JsValue` objects.
*/
class JsValue
{
friend class JsEngine;
@@ -116,26 +118,26 @@ namespace AdblockPlus
std::string GetClass() const;
/**
* Invokes the value as a function (see `IsFunction()`).
* @param params Optional list of parameters.
* @param thisPtr Optional `this` value.
* @return Value returned by the function.
*/
- JsValuePtr Call(const JsValueList& params = JsValueList(),
+ JsValuePtr Call(const JsConstValueList& params = JsConstValueList(),
AdblockPlus::JsValuePtr thisPtr = AdblockPlus::JsValuePtr()) const;
/**
* Invokes the value as a function (see `IsFunction()`) with single
* parameter.
* @param arg A single required parameter.
* @return Value returned by the function.
*/
- JsValuePtr Call(const JsValue& arg) const;
+ JsValuePtr Call(const JsConstValuePtr& arg) const;
v8::Local<v8::Value> UnwrapValue() const;
protected:
JsEnginePtr jsEngine;
private:
JsValue(JsEnginePtr jsEngine, v8::Handle<v8::Value> value);
void SetProperty(const std::string& name, v8::Handle<v8::Value> val);
std::unique_ptr<v8::Persistent<v8::Value>> value;
« no previous file with comments | « include/AdblockPlus/FilterEngine.h ('k') | src/FileSystemJsObject.cpp » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld