src/GlobalJsObject.cpp - Issue 29393589: Issue 5013 - Make more methods const.- introduced JsConstValuePtr and JsConstValueList- JsValue:…

Keyboard Shortcuts

	File
u :	up to issue
m :	publish + mail comments
M :	edit review message
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line
<Enter> :	respond to / edit current comment
d :	mark current comment as done

	Issue
u :	up to list of issues
m :	publish + mail comments
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue
# :	close issue

	Comment/message editing
<Ctrl> + s or <Ctrl> + Enter :	save comment
<Esc> :	cancel edit

Unified Diff: src/GlobalJsObject.cpp

Issue 29393589: Issue 5013 - Make more methods const.- introduced JsConstValuePtr and JsConstValueList- JsValue:… (Closed) Base URL: https://hg.adblockplus.org/libadblockplus/

Patch Set: Now mostly use the single param Call() overload Created March 24, 2017, 2:10 p.m.

Use n/p to move between diff chunks; N/P to move between comments.

Jump to:

View side-by-side diff with in-line comments

Download patch

Index: src/GlobalJsObject.cpp

===================================================================

--- a/src/GlobalJsObject.cpp

+++ b/src/GlobalJsObject.cpp

@@ -57,17 +57,17 @@ namespace

Sleep(delay);

function->Call(functionArguments);

}

private:

JsValuePtr function;

int delay;

- JsValueList functionArguments;

+ JsConstValueList functionArguments;

};

v8::Handle<v8::Value> SetTimeoutCallback(const v8::Arguments& arguments)

{

TimeoutThread* timeoutThread;

try

{

AdblockPlus::JsValueList converted =

« no previous file with comments | « src/FilterEngine.cpp ('k') | src/JsValue.cpp » ('j') | no next file with comments »