Rietveld Code Review Tool
Help | Bug tracker | Discussion group | Source code

Unified Diff: src/JsEngine.cpp

Issue 29394609: Issue 5013 - bustage: use the proper type for callbackArgs. (Closed) Base URL: https://hg.adblockplus.org/libadblockplus/
Patch Set: Created March 24, 2017, 6:27 p.m.
Use n/p to move between diff chunks; N/P to move between comments.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « no previous file | no next file » | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: src/JsEngine.cpp
===================================================================
--- a/src/JsEngine.cpp
+++ b/src/JsEngine.cpp
@@ -100,17 +100,17 @@ JsEngine::TimerTask JsEngine::CreateTime
TimerTask retValue = { shared_from_this(), timerTaskInfoIterator };
return retValue;
}
void JsEngine::CallTimerTask(TimerTaskInfos::const_iterator timerTaskInfoIterator)
{
const JsContext context(shared_from_this());
JsValue callback(shared_from_this(), v8::Local<v8::Value>::New(GetIsolate(), *timerTaskInfoIterator->arguments[0]));
- JsValueList callbackArgs;
+ JsConstValueList callbackArgs;
for (int i = 2; i < timerTaskInfoIterator->arguments.size(); i++)
callbackArgs.emplace_back(new JsValue(shared_from_this(),
v8::Local<v8::Value>::New(GetIsolate(), *timerTaskInfoIterator->arguments[i])));
callback.Call(callbackArgs);
timerTaskInfos.erase(timerTaskInfoIterator);
}
AdblockPlus::JsEngine::JsEngine(const ScopedV8IsolatePtr& isolate)
« no previous file with comments | « no previous file | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld