Rietveld Code Review Tool
Help | Bug tracker | Discussion group | Source code

Issue 29397586: Issue 4919 - Make getBackupFiles in lib/filterStorage.js asynchronous (Closed)

Created:
March 29, 2017, 10:39 a.m. by Wladimir Palant
Modified:
March 29, 2017, 12:36 p.m.
Reviewers:
kzar
Base URL:
https://hg.adblockplus.org/adblockpluscore/
Visibility:
Public.

Description

Issue 4919 - Make getBackupFiles in lib/filterStorage.js asynchronous

Patch Set 1 #

Total comments: 1
Unified diffs Side-by-side diffs Delta from patch set Stats (+33 lines, -11 lines) Patch
M lib/filterStorage.js View 1 chunk +33 lines, -11 lines 1 comment Download

Messages

Total messages: 2
Wladimir Palant
March 29, 2017, 10:39 a.m. (2017-03-29 10:39:07 UTC) #1
kzar
March 29, 2017, 11:51 a.m. (2017-03-29 11:51:33 UTC) #2
I'm not too familiar with this code, but the change LGTM.

https://codereview.adblockplus.org/29397586/diff/29397587/lib/filterStorage.js
File lib/filterStorage.js (right):

https://codereview.adblockplus.org/29397586/diff/29397587/lib/filterStorage.j...
lib/filterStorage.js:741: resolve(checkBackupFile(index + 1));
The recursion here is slightly hairy but I can't think of a better alternative
either. I considered Promise.all but since we don't know how many files to check
in advance I guess that wouldn't work.

Powered by Google App Engine
This is Rietveld