Issue 5053 - Release JsValues explicitly

libadblockplus-android-webview/src/org/adblockplus/libadblockplus/android/webview/AdblockWebView.java

 /*
  * This file is part of Adblock Plus <https://adblockplus.org/>,
  * Copyright (C) 2006-2016 Eyeo GmbH
  *
  * Adblock Plus is free software: you can redistribute it and/or modify
  * it under the terms of the GNU General Public License version 3 as
  * published by the Free Software Foundation.
  *
  * Adblock Plus is distributed in the hope that it will be useful,
  * but WITHOUT ANY WARRANTY; without even the implied warranty of
@@ skipping 972 matching lines @@
           selectorsString = EMPTY_ELEMHIDE_ARRAY_STRING;
         }
         else
         {
           String[] referrers = new String[]
             {
               url
             };
 
           List<Subscription> subscriptions = adblockEngine.getFilterEngine().getListedSubscriptions();
-          d("Listed subscriptions: " + subscriptions.size());
-          if (debugMode)
+          try
+          {
+            d("Listed subscriptions: " + subscriptions.size());
+            if (debugMode)

[diegocarloslima, 2017/03/30 14:19:29]

Isn't this check redundant here, since d() already checks for debugMode?

[anton, 2017/03/30 14:34:15]

Acknowledged. Bu it's scope of scope of this task/review.
Create separate issue for it if necessary.

+            {
+              for (Subscription eachSubscription : subscriptions)
+              {
+                d("Subscribed to " + eachSubscription);
+              }
+            }
+          }
+          finally
           {
             for (Subscription eachSubscription : subscriptions)
             {
-              d("Subscribed to " + eachSubscription);
+              eachSubscription.dispose();
             }
           }
 
           d("Requesting elemhide selectors from AdblockEngine for " + url + " in " + this);
           List<String> selectors = adblockEngine.getElementHidingSelectors(url, domain, referrers);
           d("Finished requesting elemhide selectors, got " + selectors.size() + " in " + this);
           selectorsString = Utils.stringListToJsonArray(selectors);
         }
       }
       finally
@@ skipping 406 matching lines @@
         w("Busy with elemhide selectors, delayed disposing scheduled");
         elemHideThread.setFinishedRunnable(disposeRunnable);
       }
       else
       {
         disposeRunnable.run();
       }
     }
   }
 }