Issue 5053 - Release JsValues explicitly

libadblockplus-android/src/org/adblockplus/libadblockplus/android/AndroidWebRequest.java

 /*
  * This file is part of Adblock Plus <https://adblockplus.org/>,
  * Copyright (C) 2006-2016 Eyeo GmbH
  *
  * Adblock Plus is free software: you can redistribute it and/or modify
  * it under the terms of the GNU General Public License version 3 as
  * published by the Free Software Foundation.
  *
  * Adblock Plus is distributed in the hope that it will be useful,
  * but WITHOUT ANY WARRANTY; without even the implied warranty of
@@ skipping 13 matching lines @@
 import java.net.URL;
 import java.util.HashSet;
 import java.util.LinkedList;
 import java.util.List;
 import java.util.Map;
 import java.util.zip.GZIPInputStream;
 
 import org.adblockplus.libadblockplus.AdblockPlusException;
 import org.adblockplus.libadblockplus.FilterEngine;
 import org.adblockplus.libadblockplus.HeaderEntry;
+import org.adblockplus.libadblockplus.JsValue;
 import org.adblockplus.libadblockplus.ServerResponse;
 import org.adblockplus.libadblockplus.ServerResponse.NsStatus;
 import org.adblockplus.libadblockplus.WebRequest;
 
 import android.util.Log;
 
 public class AndroidWebRequest extends WebRequest
 {
   protected static final String ENCODING_GZIP = "gzip";
   protected static final String ENCODING_IDENTITY = "identity";
@@ skipping 32 matching lines @@
       toCheck = toCheck.substring(0, idx);
     }
 
     return this.subscriptionURLs.contains(toCheck);
   }
 
   protected void updateSubscriptionURLs(final FilterEngine engine)
   {
     for (final org.adblockplus.libadblockplus.Subscription s : engine.fetchAvailableSubscriptions())
     {
-      this.subscriptionURLs.add(s.getProperty("url").toString());
+      try
+      {
+        JsValue jsUrl = s.getProperty("url");
+        try
+        {
+          this.subscriptionURLs.add(jsUrl.toString());
+        }
+        finally
+        {
+          jsUrl.dispose();
+        }
+      }
+      finally
+      {
+        s.dispose();
+      }
     }
-    this.subscriptionURLs.add(engine.getPref("subscriptions_exceptionsurl").toString());
+    JsValue jsPref = engine.getPref("subscriptions_exceptionsurl");
+    try
+    {
+      this.subscriptionURLs.add(jsPref.toString());
+    }
+    finally
+    {
+      jsPref.dispose();
+    }
   }
 
   @Override
   public ServerResponse httpGET(final String urlStr, final List<HeaderEntry> headers)
   {
     try
     {
       final URL url = new URL(urlStr);
       Log.d(TAG, "Downloading from: " + url);
 
@@ skipping 61 matching lines @@
       Log.d(TAG, "Downloading finished");
       return response;
     }
     catch (final Throwable t)
     {
       Log.e(TAG, "WebRequest failed", t);
       throw new AdblockPlusException("WebRequest failed", t);
     }
   }
 }