Rietveld Code Review Tool
Help | Bug tracker | Discussion group | Source code

Delta Between Two Patch Sets: lib/filterListener.js

Issue 29397663: Noissue - Fix a break when loading adblockpluscore into Chrome extension (Closed) Base URL: https://hg.adblockplus.org/adblockpluscore/
Left Patch Set: Created March 29, 2017, 9:10 p.m.
Right Patch Set: Added eslint hints Created March 29, 2017, 9:34 p.m.
Left:
Right:
Use n/p to move between diff chunks; N/P to move between comments.
Jump to:
Left: Side by side diff | Download
Right: Side by side diff | Download
« no previous file with change/comment | « no previous file | lib/filterStorage.js » ('j') | no next file with change/comment »
Toggle Intra-line Diffs ('i') | Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
LEFTRIGHT
1 /* globals XPCOM, XPCOMUtils, Services */
1 /* 2 /*
2 * This file is part of Adblock Plus <https://adblockplus.org/>, 3 * This file is part of Adblock Plus <https://adblockplus.org/>,
3 * Copyright (C) 2006-2016 Eyeo GmbH 4 * Copyright (C) 2006-2017 eyeo GmbH
4 * 5 *
5 * Adblock Plus is free software: you can redistribute it and/or modify 6 * Adblock Plus is free software: you can redistribute it and/or modify
6 * it under the terms of the GNU General Public License version 3 as 7 * it under the terms of the GNU General Public License version 3 as
7 * published by the Free Software Foundation. 8 * published by the Free Software Foundation.
8 * 9 *
9 * Adblock Plus is distributed in the hope that it will be useful, 10 * Adblock Plus is distributed in the hope that it will be useful,
10 * but WITHOUT ANY WARRANTY; without even the implied warranty of 11 * but WITHOUT ANY WARRANTY; without even the implied warranty of
11 * MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE. See the 12 * MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE. See the
12 * GNU General Public License for more details. 13 * GNU General Public License for more details.
13 * 14 *
14 * You should have received a copy of the GNU General Public License 15 * You should have received a copy of the GNU General Public License
15 * along with Adblock Plus. If not, see <http://www.gnu.org/licenses/>. 16 * along with Adblock Plus. If not, see <http://www.gnu.org/licenses/>.
16 */ 17 */
17 18
18 "use strict"; 19 "use strict";
19 20
20 /** 21 /**
21 * @fileOverview Component synchronizing filter storage with Matcher 22 * @fileOverview Component synchronizing filter storage with Matcher
22 * instances and ElemHide. 23 * instances and ElemHide.
23 */ 24 */
24 25
25 Cu.import("resource://gre/modules/XPCOMUtils.jsm"); 26 Cu.import("resource://gre/modules/XPCOMUtils.jsm");
kzar 2017/03/30 05:30:07 Nit: It seems you changed the order of these impor
26 Cu.import("resource://gre/modules/Services.jsm"); 27 Cu.import("resource://gre/modules/Services.jsm");
27 28
28 const {FilterStorage} = require("filterStorage"); 29 const {FilterStorage} = require("filterStorage");
29 const {FilterNotifier} = require("filterNotifier"); 30 const {FilterNotifier} = require("filterNotifier");
30 const {ElemHide} = require("elemHide"); 31 const {ElemHide} = require("elemHide");
31 const {ElemHideEmulation} = require("elemHideEmulation"); 32 const {ElemHideEmulation} = require("elemHideEmulation");
32 const {defaultMatcher} = require("matcher"); 33 const {defaultMatcher} = require("matcher");
33 const {ActiveFilter, RegExpFilter, 34 const {ActiveFilter, RegExpFilter,
34 ElemHideBase, ElemHideEmulationFilter} = require("filterClasses"); 35 ElemHideBase, ElemHideEmulationFilter} = require("filterClasses");
35 const {Prefs} = require("prefs"); 36 const {Prefs} = require("prefs");
(...skipping 275 matching lines...) Expand 10 before | Expand all | Expand 10 after
311 { 312 {
312 if (!subscription.disabled) 313 if (!subscription.disabled)
313 addFilters(subscription.filters); 314 addFilters(subscription.filters);
314 } 315 }
315 } 316 }
316 317
317 function onSave() 318 function onSave()
318 { 319 {
319 isDirty = 0; 320 isDirty = 0;
320 } 321 }
LEFTRIGHT

Powered by Google App Engine
This is Rietveld