lib/filterStorage.js - Issue 29397663: Noissue - Fix a break when loading adblockpluscore into Chrome extension

Keyboard Shortcuts

	File
u :	up to issue
m :	publish + mail comments
M :	edit review message
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line
<Enter> :	respond to / edit current comment
d :	mark current comment as done

	Issue
u :	up to list of issues
m :	publish + mail comments
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue
# :	close issue

	Comment/message editing
<Ctrl> + s or <Ctrl> + Enter :	save comment
<Esc> :	cancel edit

Delta Between Two Patch Sets: lib/filterStorage.js

Issue 29397663: Noissue - Fix a break when loading adblockpluscore into Chrome extension (Closed) Base URL: https://hg.adblockplus.org/adblockpluscore/

Left Patch Set: Created March 29, 2017, 9:10 p.m.

Right Patch Set: Added eslint hints Created March 29, 2017, 9:34 p.m.

Left:
Right:

Use n/p to move between diff chunks; N/P to move between comments.

Jump to:

Left: Side by side diff | Download
Right: Side by side diff | Download

LEFT	RIGHT
	1 /* global Services, FileUtils */

1 /*	2 /*

2 * This file is part of Adblock Plus <https://adblockplus.org/>,	3 * This file is part of Adblock Plus <https://adblockplus.org/>,

3 * Copyright (C) 2006-2016 Eyeo GmbH	4 * Copyright (C) 2006-2017 eyeo GmbH

4 *	5 *

5 * Adblock Plus is free software: you can redistribute it and/or modify	6 * Adblock Plus is free software: you can redistribute it and/or modify

6 * it under the terms of the GNU General Public License version 3 as	7 * it under the terms of the GNU General Public License version 3 as

7 * published by the Free Software Foundation.	8 * published by the Free Software Foundation.

8 *	9 *

9 * Adblock Plus is distributed in the hope that it will be useful,	10 * Adblock Plus is distributed in the hope that it will be useful,

10 * but WITHOUT ANY WARRANTY; without even the implied warranty of	11 * but WITHOUT ANY WARRANTY; without even the implied warranty of

11 * MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE. See the	12 * MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE. See the

12 * GNU General Public License for more details.	13 * GNU General Public License for more details.

13 *	14 *

(...skipping 851 matching lines...) Expand 10 before \| Expand all \| Expand 10 after Loading...
865 Subscription.knownSubscriptions = origKnownSubscriptions;	866 Subscription.knownSubscriptions = origKnownSubscriptions;

866 }	867 }

867	868

868 // Allow events to be processed every now and then.	869 // Allow events to be processed every now and then.

869 // Note: IO.readFromFile() will deal with the potential reentrance here.	870 // Note: IO.readFromFile() will deal with the potential reentrance here.

870 this.linesProcessed++;	871 this.linesProcessed++;

871 if (this.linesProcessed % 1000 == 0)	872 if (this.linesProcessed % 1000 == 0)

872 return Utils.yield();	873 return Utils.yield();

873 }	874 }

874 };	875 };

LEFT	RIGHT