Rietveld Code Review Tool
Help | Bug tracker | Discussion group | Source code | Sign in
(77)

Issue 29398651: Issue 5061 - Update adblockpluscore dependency to 3bdddf0e8343 (Closed)

Can't Edit
Can't Publish+Mail
Start Review
Created:
2 years, 4 months ago by kzar
Modified:
2 years, 4 months ago
Reviewers:
Sebastian Noack
Visibility:
Public.

Description

Issue 5061 - Update adblockpluscore dependency to 3bdddf0e8343 Based upon the changes here https://codereview.adblockplus.org/29374674/

Patch Set 1 #

Total comments: 3

Patch Set 2 : Update dependency further #

Unified diffs Side-by-side diffs Delta from patch set Stats (+18 lines, -8 lines) Patch
M dependencies View 1 1 chunk +1 line, -1 line 0 comments Download
M lib/compat.js View 4 chunks +17 lines, -7 lines 0 comments Download

Messages

Total messages: 6
kzar
Patch Set 1
2 years, 4 months ago (2017-03-30 07:34:56 UTC) #1
Sebastian Noack
https://codereview.adblockplus.org/29398651/diff/29398652/dependencies File dependencies (right): https://codereview.adblockplus.org/29398651/diff/29398652/dependencies#newcode5 dependencies:5: adblockpluscore = adblockpluscore hg:68a4dc4e79e8 git:2574147 While there is a ...
2 years, 4 months ago (2017-03-30 08:02:30 UTC) #2
kzar
On 2017/03/30 08:02:30, Sebastian Noack wrote: > While there is a separate issue for this ...
2 years, 4 months ago (2017-03-30 09:21:08 UTC) #3
Sebastian Noack
https://codereview.adblockplus.org/29398651/diff/29398652/dependencies File dependencies (right): https://codereview.adblockplus.org/29398651/diff/29398652/dependencies#newcode5 dependencies:5: adblockpluscore = adblockpluscore hg:68a4dc4e79e8 git:2574147 On 2017/03/30 09:21:08, kzar ...
2 years, 4 months ago (2017-03-30 10:54:34 UTC) #4
kzar
Patch Set 2 : Update dependency further https://codereview.adblockplus.org/29398651/diff/29398652/dependencies File dependencies (right): https://codereview.adblockplus.org/29398651/diff/29398652/dependencies#newcode5 dependencies:5: adblockpluscore = ...
2 years, 4 months ago (2017-03-30 13:56:32 UTC) #5
Sebastian Noack
2 years, 4 months ago (2017-03-30 14:38:28 UTC) #6
LGTM
Sign in to reply to this message.

Powered by Google App Engine
RSS Feeds Recent Issues | This issue
This is Rietveld 87257f5