Rietveld Code Review Tool
Help | Bug tracker | Discussion group | Source code

Issue 29398708: Issue 5051 - Make sure that custom backups don't rely on FilterStorage's I/O (Closed)

Created:
March 30, 2017, 12:23 p.m. by Wladimir Palant
Modified:
March 31, 2017, 3:46 a.m.
Reviewers:
kzar
Base URL:
https://hg.adblockplus.org/adblockplus
Visibility:
Public.

Description

Issue 5051 - Make sure that custom backups don't rely on FilterStorage's I/O

Patch Set 1 #

Total comments: 1

Patch Set 2 : Added revision IDs #

Unified diffs Side-by-side diffs Delta from patch set Stats (+37 lines, -27 lines) Patch
M chrome/content/ui/filters-backup.js View 3 chunks +36 lines, -26 lines 0 comments Download
M dependencies View 1 1 chunk +1 line, -1 line 0 comments Download

Messages

Total messages: 5
Wladimir Palant
March 30, 2017, 12:23 p.m. (2017-03-30 12:23:25 UTC) #1
Wladimir Palant
https://codereview.adblockplus.org/29398708/diff/29398709/dependencies File dependencies (right): https://codereview.adblockplus.org/29398708/diff/29398709/dependencies#newcode4 dependencies:4: adblockpluscore = adblockpluscore hg:tip git:bb21628 This depends on changes ...
March 30, 2017, 12:23 p.m. (2017-03-30 12:23:58 UTC) #2
kzar
I can't see anything obviously wrong. LGTM after proper revisions are added.
March 30, 2017, 1:25 p.m. (2017-03-30 13:25:05 UTC) #3
Wladimir Palant
Correct revision IDs have been added.
March 30, 2017, 4:45 p.m. (2017-03-30 16:45:49 UTC) #4
kzar
March 31, 2017, 3:46 a.m. (2017-03-31 03:46:31 UTC) #5
Message was sent while issue was closed.
On 2017/03/30 16:45:49, Wladimir Palant wrote:
> Correct revision IDs have been added.

LGTM

Powered by Google App Engine
This is Rietveld