Issue 5051 - Make sure that custom backups don't rely on FilterStorage's I/O

chrome/content/ui/filters-backup.js

 /*
  * This file is part of Adblock Plus <https://adblockplus.org/>,
  * Copyright (C) 2006-2017 eyeo GmbH
  *
  * Adblock Plus is free software: you can redistribute it and/or modify
  * it under the terms of the GNU General Public License version 3 as
  * published by the Free Software Foundation.
  *
  * Adblock Plus is distributed in the hope that it will be useful,
  * but WITHOUT ANY WARRANTY; without even the implied warranty of
@@ skipping 90 matching lines @@
     {
       backups.reverse();
       for (let backup of backups)
       {
         let item = this.restoreTemplate.cloneNode(true);
         let label = item.getAttribute("label");
         label = label.replace(/\?1\?/, Utils.formatTime(backup.lastModified));
         item.setAttribute("label", label);
         item.addEventListener("command", function()
         {
-          Backup.restoreAllData(backup.file);
+          FilterStorage.restoreBackup(backup.index);
         }, false);
         this.restoreInsertionPoint.parentNode.insertBefore(item, this.restoreInsertionPoint.nextSibling);
       }
     });
   },
 
   /**
    * Lets the user choose a file to restore filters from.
    */
   restoreFromFile: function()
@@ skipping 12 matching lines @@
       else
         this.restoreCustomFilters(picker.file);
     }
   },
 
   /**
    * Restores patterns.ini from a file.
    */
   restoreAllData: function(/**nsIFile*/ file)
   {
-    let stream = Cc["@mozilla.org/network/file-input-stream;1"].createInstance(Ci.nsIFileInputStream);
-    stream.init(file, FileUtils.MODE_RDONLY, FileUtils.PERMS_FILE, 0);
-    stream.QueryInterface(Ci.nsILineInputStream);
+    let sink = FilterStorage.importData();
+    let lines = [];
+    IO.readFromFile(file, {
+      process(line)
+      {
+        if (line === null)
+        {
+          let match;
+          if (lines.length < 2 || lines[0] != "# Adblock Plus preferences" || !(match = /version=(\d+)/.exec(lines[1])))
+          {
+            Utils.alert(window, E("backupButton").getAttribute("_restoreError"), E("backupButton").getAttribute("_restoreDialogTitle"));
+            return;
+          }
 
-    let lines = [];
-    let line = {value: null};
-    if (stream.readLine(line))
-      lines.push(line.value);
-    if (stream.readLine(line))
-      lines.push(line.value);
-    stream.close();
+          let warning = E("backupButton").getAttribute("_restoreCompleteWarning");
+          let minVersion = parseInt(match[1], 10);
+          if (minVersion > FilterStorage.formatVersion)
+            warning += "\n\n" + E("backupButton").getAttribute("_restoreVersionWarning");
 
-    let match;
-    if (lines.length < 2 || lines[0] != "# Adblock Plus preferences" || !(match = /version=(\d+)/.exec(lines[1])))
+          if (!Utils.confirm(window, warning, E("backupButton").getAttribute("_restoreDialogTitle")))
+            return;
+        }
+        else if (lines.length < 2)
+          lines.push(line);
+
+        sink(line);
+      }
+    }, error =>
     {
-      Utils.alert(window, E("backupButton").getAttribute("_restoreError"), E("backupButton").getAttribute("_restoreDialogTitle"));
-      return;
-    }
-
-    let warning = E("backupButton").getAttribute("_restoreCompleteWarning");
-    let minVersion = parseInt(match[1], 10);
-    if (minVersion > FilterStorage.formatVersion)
-      warning += "\n\n" + E("backupButton").getAttribute("_restoreVersionWarning");
-
-    if (!Utils.confirm(window, warning, E("backupButton").getAttribute("_restoreDialogTitle")))
-      return;
-
-    FilterStorage.loadFromDisk(file);
+      if (error)
+        alert(error);
+      else
+        FilterStorage.saveToDisk();
+    });
   },
 
   /**
    * Restores custom filters from a file.
    */
   restoreCustomFilters: function(/**nsIFile*/ file)
   {
     IO.readFromFile(file, {
       seenHeader: false,
       subscription: null,
@@ skipping 95 matching lines @@
       else
         this.backupCustomFilters(picker.file);
     }
   },
 
   /**
    * Writes all patterns.ini data to a file.
    */
   backupAllData: function(/**nsIFile*/ file)
   {
-    FilterStorage.saveToDisk(file);
+    IO.writeToFile(file, FilterStorage.exportData(), error =>
+    {
+      if (error)
+        alert(error);
+    });
   },
 
   /**
    * Writes user's custom filters to a file.
    */
   backupCustomFilters: function(/**nsIFile*/ file)
   {
     let subscriptions = FilterStorage.subscriptions.filter(s => s instanceof SpecialSubscription);
     let minVersion = "2.0"
     let list = [];
@@ skipping 50 matching lines @@
         Utils.alert(window, E("backupButton").getAttribute("_backupError"), E("backupButton").getAttribute("_backupDialogTitle"));
       }
     });
   }
 };
 
 window.addEventListener("load", function()
 {
   Backup.init();
 }, false);