libadblockplus-android/jni/JniJsEngine.cpp - Issue 29398811: Issue 5075 - JsEngine crashes in dtor with LogSystemPtr ref

Keyboard Shortcuts

	File
u :	up to issue
m :	publish + mail comments
M :	edit review message
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line
<Enter> :	respond to / edit current comment
d :	mark current comment as done

	Issue
u :	up to list of issues
m :	publish + mail comments
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue
# :	close issue

	Comment/message editing
<Ctrl> + s or <Ctrl> + Enter :	save comment
<Esc> :	cancel edit

Unified Diff: libadblockplus-android/jni/JniJsEngine.cpp

Issue 29398811: Issue 5075 - JsEngine crashes in dtor with LogSystemPtr ref (Closed)

Patch Set: Created March 30, 2017, 10:27 p.m.

Use n/p to move between diff chunks; N/P to move between comments.

Jump to:

Index: libadblockplus-android/jni/JniJsEngine.cpp

diff --git a/libadblockplus-android/jni/JniJsEngine.cpp b/libadblockplus-android/jni/JniJsEngine.cpp

index e33673593552996dc7f795ac6402867115cdcf9f..a0481730e4aa4c33b1db60cc45f74ad074b55c1d 100644

--- a/libadblockplus-android/jni/JniJsEngine.cpp

+++ b/libadblockplus-android/jni/JniJsEngine.cpp

@@ -168,7 +168,7 @@ static void JNICALL JniSetLogSystem(JNIEnv* env, jclass clazz, jlong ptr, jlong

try

{

- AdblockPlus::LogSystemPtr logSystem(JniLongToTypePtr<JniLogSystemCallback>(logSystemPtr));

+ AdblockPlus::LogSystemPtr logSystem = *JniLongToTypePtr<AdblockPlus::LogSystemPtr>(logSystemPtr);

engine->SetLogSystem(logSystem);

}

« no previous file with comments | « no previous file | no next file » | no next file with comments »